Merged PR 693279: Increase ProcessDumper default depth to 20

mpysson · mpysson · commit 087359a9c35a · 2022-12-12T17:06:44.000-08:00
This is a short term mitigation to allow some builds with timeouts to be investigated where the process tree depth is greater than 20.

Related work items: #2015851
diff --git a/Public/Src/Engine/Processes/ProcessDumper.cs b/Public/Src/Engine/Processes/ProcessDumper.cs
@@ -155,7 +155,7 @@ public static bool TryDumpProcess(IntPtr processHandle, int processId, string du
         /// <summary>
         /// Attempts to dump all processes in a process tree. Any files existing in the dump directory will be deleted.
         /// </summary>
-        public static bool TryDumpProcessAndChildren(int parentProcessId, string dumpDirectory, out Exception primaryDumpCreationException, int maxTreeDepth = 10, Action<string> debugLogger = null)
+        public static bool TryDumpProcessAndChildren(int parentProcessId, string dumpDirectory, out Exception primaryDumpCreationException, int maxTreeDepth = 20, Action<string> debugLogger = null)
         {
             if (OperatingSystemHelper.IsMacOS)
             {

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public static bool TryDumpProcess(IntPtr processHandle, int processId, string du`
`155`	`155`	`/// <summary>`
`156`	`156`	`/// Attempts to dump all processes in a process tree. Any files existing in the dump directory will be deleted.`
`157`	`157`	`/// </summary>`
`158`		`- public static bool TryDumpProcessAndChildren(int parentProcessId, string dumpDirectory, out Exception primaryDumpCreationException, int maxTreeDepth = 10, Action<string> debugLogger = null)`
	`158`	`+ public static bool TryDumpProcessAndChildren(int parentProcessId, string dumpDirectory, out Exception primaryDumpCreationException, int maxTreeDepth = 20, Action<string> debugLogger = null)`
`159`	`159`	`{`
`160`	`160`	`if (OperatingSystemHelper.IsMacOS)`
`161`	`161`	`{`