Merge main into docs/al-docs/shopify

Author: Groenbech96

.github/AL-Go-Settings.json

@@ -6,7 +6,7 @@
   "runs-on": "windows-latest",
   "cacheImageName": "",
   "UsePsSession": false,
-  "artifact": "bcinsider/Sandbox/29.0.47702.0//latest",
+  "artifact": "bcinsider/Sandbox/29.0.47831.0//latest",
   "country": "base",
   "useProjectDependencies": true,
   "incrementalBuilds": {

src/Apps/W1/APIReportsFinance/App/CLAUDE.md

@@ -0,0 +1,62 @@
+# API Reports - Finance
+
+Read-only API layer that exposes raw financial data (GL entries, customer/vendor
+ledger entries, budgets, dimensions) through OData/REST endpoints. Unlike the
+standard BC API v2.0 financial endpoints (trialBalance, balanceSheet, etc.) which
+return pre-aggregated report data, this app exposes granular transactional records
+that consumers aggregate themselves -- a "data warehouse" approach for building
+custom financial reports.
+
+## Quick reference
+
+- **ID range**: 30300--30399
+- **Namespace**: Microsoft.API.FinancialManagement
+- **API route**: `api/microsoft/reportsFinance/beta/`
+- **API version**: beta (not GA -- endpoints may change)
+
+## How it works
+
+The app defines 9 API Pages and 6 API Queries, all read-only. Pages expose
+master/reference data (chart of accounts, customers, vendors, dimensions,
+budgets, accounting periods, business units, global settings). Queries expose
+transactional data (GL entries, GL budget entries, customer ledger entries,
+detailed customer ledger entries, vendor ledger entries, detailed vendor ledger
+entries).
+
+Every object follows the same template: `PageType = API` or `QueryType = API`,
+`DataAccessIntent = ReadOnly`, all insert/modify/delete disabled, `ODataKeyFields
+= SystemId`. The app defines no tables of its own -- it reads directly from base
+app tables (G/L Entry, Cust. Ledger Entry, etc.).
+
+The only procedural logic lives in two page triggers:
+
+- **Accounting Periods** (`APIFinanceAccPeriods.Page.al`): computes
+  `FiscalYearStartDate`, `FiscalYearEndDate`, and `EndingDate` on each record
+  fetch. The ending date is derived by peeking at the next period's start date
+  and subtracting one day.
+
+- **GL Accounts** (`APIFinanceGLAccount.Page.al`): reconstructs the chart of
+  accounts parent-child hierarchy at runtime using a `Dictionary<Integer,
+  Code[20]>` keyed by indentation level. This is order-dependent -- it relies on
+  records arriving sorted by account number with ascending indentation.
+
+## Things to know
+
+- All 15 data endpoints are completely read-only. There is zero write logic, zero
+  events, zero extensibility hooks, and zero codeunits.
+- The GL Account parent tracking via dictionary is fragile. It works because API
+  pages iterate records in sort order, but the pattern wouldn't survive
+  re-sorting or filtering that breaks indentation sequencing.
+- `globalSettings` is a virtual page -- it reads from both the Company record and
+  General Ledger Setup in `OnOpenPage`, exposing just company name, LCY code, and
+  additional reporting currency.
+- The app has several caption typos in the query objects: `entryType` is captioned
+  as `'Entry Number'` in both detailed ledger entry queries, and
+  `initialEntryGlobalDim2` is captioned as `'...Dimension 1'` instead of
+  `'...Dimension 2'`.
+- The `reveresd` column name in `APIFinanceGLEntry.Query.al` is a typo for
+  `reversed`.
+- GL Budget Entry query has a duplicate column: both `accountNo` and
+  `generalLedgerAccountNumber` map to the same `G/L Account No.` field.
+- Permissions follow the standard stacking pattern: one base permission set
+  (`API Reports Finance - Objects`) extended into 6 D365 roles.

src/Apps/W1/DataCorrectionFA/App/CLAUDE.md

@@ -0,0 +1,50 @@
+# Troubleshoot FA Ledger Entries
+
+This app detects and corrects rounding issues in Fixed Asset ledger entries. Some FA entries end up with amounts that have more decimal places than the currency's rounding precision allows (e.g., 1234.567 when precision is 0.01), which can cause downstream posting and reporting problems. The app scans for these entries, shows them to the user on the Fixed Asset Card via a notification, and lets them accept a rounded correction that writes directly back to the FA Ledger Entry table.
+
+## Quick reference
+
+| Item | Value |
+|------|-------|
+| ID range | 6090-6099 |
+| Namespace | `Microsoft.FixedAssets.Repair` |
+| Dependencies | None (base app + platform only) |
+| App ID | `7961e9dc-a8e5-49b1-839b-3a78803a4cb8` |
+| Object count | 1 table, 1 tableextension, 2 codeunits, 1 page, 10 permission objects |
+
+## How it works
+
+The app uses a **shadow table** pattern. Rather than flagging issues on the real FA Ledger Entry table, it copies problematic entries into its own staging table (`FA Ledg. Entry w. Issue`, table 6090). This avoids modifying production data during the detection phase and gives users a safe review step before any corrections happen.
+
+**Detection** is handled by codeunit 6090 `FA Ledger Entries Scan`. It iterates FA Ledger Entries starting from a high-water mark stored on FA Setup (`LastEntryNo`), compares each entry's Amount to `Round(Amount, Currency."Amount Rounding Precision")`, and copies mismatched entries into the issues table. The scan is incremental -- it only looks at entries newer than the last scan, so repeated runs are cheap. The high-water mark advances to one past the last entry checked.
+
+**Triggering** the scan is lazy and background-based. When a user opens a Fixed Asset Card, codeunit 6091 `FA Card Notifications` subscribes to `OnAfterGetCurrRecordEvent`. It checks a cooldown (7 days, stored as `Last time scanned` on FA Setup) and if enough time has passed, schedules the scan as a background task via `TaskScheduler.CreateTask` with a 1-second delay. This keeps the UI responsive -- the scan never blocks the page load. The notification only appears if the issues table already has uncorrected entries for that specific FA.
+
+**Correction** happens on page 6090 `FA Ledger Entries Issues`. The user selects entries and clicks "Accept Selected". The page action directly modifies the real `FA Ledger Entry` record: it rounds the Amount, recalculates Debit/Credit amounts respecting the Correction flag, and marks the shadow entry as corrected. This is a permanent write to posted ledger entries -- there is no reversal mechanism.
+
+## Structure
+
+- **`src/tables/`** -- The shadow table for flagged entries and a tableextension on FA Setup for scan state (high-water mark, last scan timestamp).
+- **`src/codeunits/`** -- Scanner that detects rounding issues, and notification handler that wires into the Fixed Asset Card page.
+- **`src/pages/`** -- Review and correction page where users inspect flagged entries and accept fixes.
+- **`Permissions/`** -- Standard permission scaffolding. Extends D365 AUTOMATION, BASIC ISV, BUS FULL ACCESS, BUS PREMIUM, FA EDIT, and FULL ACCESS sets. The layered sets (Objects/Read/Edit) follow the BC permission set pattern.
+
+## Things to know
+
+- **The app modifies posted ledger entries directly.** The "Accept Selected" action writes to `FA Ledger Entry` without creating correcting entries or journal lines. This is unusual in BC where posted entries are typically immutable. The design is intentional -- these are sub-penny rounding fixes, not business corrections.
+
+- **The scan is incremental, not full-table.** `FASetup.LastEntryNo` acts as a checkpoint. If you need to re-scan previously checked entries (e.g., after changing currency rounding precision), you would need to reset this field manually.
+
+- **The 7-day cooldown is hardcoded.** `GetCacheRefreshInterval()` returns a fixed 1-week duration. There is no setup field to configure this. The cooldown prevents the scan from being scheduled on every Fixed Asset Card open.
+
+- **Scan runs as a background task, not inline.** `TaskScheduler.CreateTask` means the scan executes in a separate session. The notification on the FA Card shows results from the *previous* scan, not a live check. A user opening the card for the first time after install will not see a notification until after the background task completes and they revisit the card.
+
+- **The Amount field on the issues table stores the already-rounded value, not the original.** `TransferFields` copies from FA Ledger Entry, then the page's `OnAfterGetRecord` recalculates the original amount display and rounding difference on the fly. The `OriginalAmount` and `Rounding` columns on the page are computed, not stored.
+
+- **Debit/Credit recalculation respects the Correction flag.** When rounding the amount, the code checks both the sign of the amount and the `Correction` boolean to determine which side (Debit vs Credit) gets the value. This mirrors standard BC posting logic where correction entries flip the normal debit/credit assignment.
+
+- **No events are published.** The app subscribes to the FA Card page event but does not expose any integration or business events of its own. There are no extension points for customizing the scan logic or correction behavior.
+
+- **Permission set extensions grant RIMD on the shadow table to all major D365 entitlements.** This means any user with standard BC licensing can see and interact with the correction page. The page itself also declares inline `Permissions` for both the shadow table and the real FA Ledger Entry table (RIMD on both).
+
+- **The `Commit()` calls in both codeunits are deliberate lock-release patterns.** The scan codeunit locks FA Setup to update the timestamp, then commits to release the lock before the potentially long-running scan loop. The notification codeunit does the same before scheduling the background task.

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/ClosedCustContLineSubp.Page.al

@@ -1,5 +1,6 @@
 namespace Microsoft.SubscriptionBilling;
 
+using Microsoft.Finance.Dimension;
 using Microsoft.Inventory.Item;
 
 page 8080 "Closed Cust. Cont. Line Subp."
@@ -298,6 +299,24 @@ page 8080 "Closed Cust. Cont. Line Subp."
                     Visible = false;
                     Editable = false;
                 }
+                field("Shortcut Dimension 1 Code"; ServiceCommitment."Shortcut Dimension 1 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Caption = 'Shortcut Dimension 1 Code';
+                    CaptionClass = '1,2,1';
+                    ToolTip = 'Specifies the code for Shortcut Dimension 1, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    Visible = false;
+                    Editable = false;
+                }
+                field("Shortcut Dimension 2 Code"; ServiceCommitment."Shortcut Dimension 2 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Caption = 'Shortcut Dimension 2 Code';
+                    CaptionClass = '1,2,2';
+                    ToolTip = 'Specifies the code for Shortcut Dimension 2, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    Visible = false;
+                    Editable = false;
+                }
             }
         }
     }
@@ -309,6 +328,21 @@ page 8080 "Closed Cust. Cont. Line Subp."
             {
                 Caption = 'Contract Line';
                 Image = "Item";
+                action(Dimensions)
+                {
+                    AccessByPermission = tabledata Dimension = R;
+                    ApplicationArea = Dimensions;
+                    Caption = 'Dimensions';
+                    Image = Dimensions;
+                    Scope = Repeater;
+                    ShortcutKey = 'Shift+Ctrl+D';
+                    ToolTip = 'View or edit dimensions, such as area, project, or department, that you can assign to sales and purchase documents to distribute costs and analyze transaction history.';
+
+                    trigger OnAction()
+                    begin
+                        ServiceCommitment.EditDimensionSet();
+                    end;
+                }
                 action(ShowArchivedBillingLines)
                 {
                     Caption = 'Archived Billing Lines';

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/CustomerContractLineSubp.Page.al

@@ -493,6 +493,50 @@ page 8068 "Customer Contract Line Subp."
                         UpdateServiceCommitmentOnPage(ServiceCommitment.FieldNo("Currency Factor Date"));
                     end;
                 }
+                field("Shortcut Dimension 1 Code"; ServiceCommitment."Shortcut Dimension 1 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Caption = 'Shortcut Dimension 1 Code';
+                    CaptionClass = '1,2,1';
+                    ToolTip = 'Specifies the code for Shortcut Dimension 1, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    Visible = false;
+                    Editable = not IsCommentLineEditable;
+                    Enabled = not IsCommentLineEditable;
+
+                    trigger OnLookup(var Text: Text): Boolean
+                    begin
+                        DimMgt.LookupDimValueCode(1, ServiceCommitment."Shortcut Dimension 1 Code");
+                        Text := ServiceCommitment."Shortcut Dimension 1 Code";
+                        exit(true);
+                    end;
+
+                    trigger OnValidate()
+                    begin
+                        UpdateServiceCommitmentOnPage(ServiceCommitment.FieldNo("Shortcut Dimension 1 Code"));
+                    end;
+                }
+                field("Shortcut Dimension 2 Code"; ServiceCommitment."Shortcut Dimension 2 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Caption = 'Shortcut Dimension 2 Code';
+                    CaptionClass = '1,2,2';
+                    ToolTip = 'Specifies the code for Shortcut Dimension 2, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    Visible = false;
+                    Editable = not IsCommentLineEditable;
+                    Enabled = not IsCommentLineEditable;
+
+                    trigger OnLookup(var Text: Text): Boolean
+                    begin
+                        DimMgt.LookupDimValueCode(2, ServiceCommitment."Shortcut Dimension 2 Code");
+                        Text := ServiceCommitment."Shortcut Dimension 2 Code";
+                        exit(true);
+                    end;
+
+                    trigger OnValidate()
+                    begin
+                        UpdateServiceCommitmentOnPage(ServiceCommitment.FieldNo("Shortcut Dimension 2 Code"));
+                    end;
+                }
             }
         }
     }
@@ -616,6 +660,7 @@ page 8068 "Customer Contract Line Subp."
 
     var
         ContractsGeneralMgt: Codeunit "Sub. Contracts General Mgt.";
+        DimMgt: Codeunit DimensionManagement;
         NextBillingDateStyleExpr: Text;
         ContractLineQty: Decimal;
         VariantCode: Code[10];

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/ServCommWOCustContract.Page.al

@@ -116,6 +116,18 @@ page 8069 "Serv. Comm. WO Cust. Contract"
                         ContactManagement.OpenContactCard(ServiceObject."End-User Contact No.");
                     end;
                 }
+                field("Shortcut Dimension 1 Code"; Rec."Shortcut Dimension 1 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Visible = false;
+                    Editable = false;
+                }
+                field("Shortcut Dimension 2 Code"; Rec."Shortcut Dimension 2 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Visible = false;
+                    Editable = false;
+                }
             }
         }
     }

src/Apps/W1/Subscription Billing/App/Service Commitments/Pages/ServiceCommitments.Page.al

@@ -266,6 +266,16 @@ page 8064 "Service Commitments"
                     ApplicationArea = All;
                     ToolTip = 'Specifies the sequence number of the related reference.';
                 }
+                field("Shortcut Dimension 1 Code"; Rec."Shortcut Dimension 1 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Visible = false;
+                }
+                field("Shortcut Dimension 2 Code"; Rec."Shortcut Dimension 2 Code")
+                {
+                    ApplicationArea = Dimensions;
+                    Visible = false;
+                }
 
             }
         }

src/Apps/W1/Subscription Billing/App/Service Commitments/Pages/ServiceCommitmentsList.Page.al

@@ -148,12 +148,12 @@ page 8014 "Service Commitments List"
                 }
                 field("Shortcut Dimension 1 Code"; Rec."Shortcut Dimension 1 Code")
                 {
-                    ToolTip = 'Specifies the code for Shortcut Dimension 1, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    ApplicationArea = Dimensions;
                     Visible = false;
                 }
                 field("Shortcut Dimension 2 Code"; Rec."Shortcut Dimension 2 Code")
                 {
-                    ToolTip = 'Specifies the code for Shortcut Dimension 2, which is one of two global dimension codes that you set up in the General Ledger Setup window.';
+                    ApplicationArea = Dimensions;
                     Visible = false;
                 }
                 field("Price (LCY)"; Rec."Price (LCY)")