[Event Requests] - codeunit 12 "Gen. Jnl.-Post Line"

[exnihiloo]

Why do you need this change?

1. Procedure PostUnapply. In our custom extension code under if UnapplyVATEntries or (VATEntry."Unrealized VAT Entry No." <> 0) then begin should aways execute.

   Example of custom code:

   local procedure PostUnapply(GenJnlLine: Record "Gen. Journal Line"; var VATEntry: Record "VAT Entry"; VATEntryType: Enum "General Posting Type"; BilltoPaytoNo: Code[20]; TransactionNo: Integer; UnapplyVATEntries: Boolean; var TempVATEntry: Record "VAT Entry" temporary)
       var
          ...
       begin
          ...
           if VATEntry.FindSet() then
               repeat
                   VATPostingSetup.Get(VATEntry."VAT Bus. Posting Group", VATEntry."VAT Prod. Posting Group");
                   OnPostUnapplyOnBeforeUnapplyVATEntry(VATEntry, UnapplyVATEntries);
                   //if UnapplyVATEntries or (VATEntry."Unrealized VAT Entry No." <> 0) then begin //Custom commented code
                       InsertTempVATEntry(GenJnlLine, VATEntry, TempVATEntryNo, TempVATEntry);
                       if VATEntry."Unrealized VAT Entry No." <> 0 then begin
         ...
       end;

Alternatives Evaluated:
We can use OnPostUnapplyOnBeforeUnapplyVATEntry to change values of UnapplyVATEntries or VATEntry."Unrealized VAT Entry No." and then code inside if UnapplyVATEntries or (VATEntry."Unrealized VAT Entry No." <> 0) statement will always execute, but we will need to return their origin values after that if check. For that we need additional event before procedure InsertTempVATEntry.

Describe the request

1. Procedure PostUnapply

   local procedure PostUnapply(GenJnlLine: Record "Gen. Journal Line"; var VATEntry: Record "VAT Entry"; VATEntryType: Enum "General Posting Type"; BilltoPaytoNo: Code[20]; TransactionNo: Integer; UnapplyVATEntries: Boolean; var TempVATEntry: Record "VAT Entry" temporary)
       var
          ...
       begin
          ...
           if VATEntry.FindSet() then
               repeat
                   VATPostingSetup.Get(VATEntry."VAT Bus. Posting Group", VATEntry."VAT Prod. Posting Group");
                   OnPostUnapplyOnBeforeUnapplyVATEntry(VATEntry, UnapplyVATEntries);
                   if UnapplyVATEntries or (VATEntry."Unrealized VAT Entry No." <> 0) then begin 
                       OnPostUnapplyOnBeforeInsertTempVATEntry(VATEntry, UnapplyVATEntries); //New event <---
                       InsertTempVATEntry(GenJnlLine, VATEntry, TempVATEntryNo, TempVATEntry);
                       if VATEntry."Unrealized VAT Entry No." <> 0 then begin
         ...
       end;
   
   [IntegrationEvent(false, false)]
   local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntry: Boolean)
   begin
   end;

Internal work item: AB#619462

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new integration event OnPostUnapplyOnBeforeInsertTempVATEntry in the PostUnapply procedure before the call to InsertTempVATEntry.

Location in PostUnapply procedure (around line 6422):

if VATEntry.FindSet() then
    repeat
        VATPostingSetup.Get(VATEntry."VAT Bus. Posting Group", VATEntry."VAT Prod. Posting Group");
        OnPostUnapplyOnBeforeUnapplyVATEntry(VATEntry, UnapplyVATEntries);
        if UnapplyVATEntries or (VATEntry."Unrealized VAT Entry No." <> 0) then begin
            OnPostUnapplyOnBeforeInsertTempVATEntry(VATEntry, UnapplyVATEntries);  // <-- New event
            InsertTempVATEntry(GenJnlLine, VATEntry, TempVATEntryNo, TempVATEntry);
            if VATEntry."Unrealized VAT Entry No." <> 0 then begin

Event Publisher (add at the end of the codeunit with other events):

[IntegrationEvent(false, false)]
local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntries: Boolean)
begin
end;

---

File: GenJnlPostLine.Codeunit.al

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 46064.