improve error handling

Author: Michalis Karagiorgos

Sources/Errors/ConfigurationLoaderError.swift

@@ -14,7 +14,7 @@ enum ConfigurationLoaderError: Error, CustomStringConvertible, Equatable {
     var description: String {
         switch self {
         case .configurationFileNotFound(let path):
-            "❌ Configuration file not found at path: \(path)"
+            "error: ❌ Configuration file not found at path: \(path)"
         }
     }
 }

Sources/Errors/DuplicatesError.swift

@@ -15,7 +15,7 @@ enum DuplicatesError: Error, CustomStringConvertible, Equatable {
     var description: String {
         switch self {
         case .duplicateEntries(let duplicates, let context):
-            "❌ Duplicate \(context) entries found:\n\(duplicates.joined(separator: ", "))"
+            "error: ❌ Duplicate \(context) entries found:\n\(duplicates.joined(separator: ", "))"
         }
     }
 }

Sources/Errors/ExclusivesError.swift

@@ -27,11 +27,11 @@ enum ExclusivesError: Error, CustomStringConvertible, Equatable {
     var description: String {
         switch self {
         case .invalidTargetName(let name):
-            "❌ Target name \(name) inside exclusive section doesn't exist in the project"
+            "error: ❌ Target name \(name) inside exclusive section doesn't exist in the project"
         case .invalidPathForTarget(let targetName, let path):
-            "❌ Path \(path) inside exclusive section for target \(targetName) doesn't exist in the project"
+            "error: ❌ Path \(path) inside exclusive section for target \(targetName) doesn't exist in the project"
         case .exclusiveEntriesFound(let targetNames):
-            "❌ Exclusive entries found for targets: \(targetNames)"
+            "error: ❌ Exclusive entries found for targets: \(targetNames)"
         }
     }
 }

Sources/Errors/ForbiddenResourceError.swift

@@ -11,7 +11,7 @@ struct ForbiddenResourceError: Error, CustomStringConvertible, Equatable {
 
     /// A human readable, multiline description enumerating each forbidden resource path found.
     var description: String {
-        "❌ Forbidden resource(s) found in target \(targetName):\n" +
+        "error: ❌ Forbidden resource(s) found in target \(targetName):\n" +
         matchingPaths
             .map { " - \($0)" }
             .sorted()

Sources/Errors/XcodeProjectParserError.swift

@@ -35,17 +35,17 @@ enum XcodeProjectParserError: Error, CustomStringConvertible, Equatable {
     var description: String {
         switch self {
         case .invalidTargetName(let name):
-            "❌ Invalid target name \(name)"
+            "error: ❌ Invalid target name \(name)"
         case .invalidPath(let path):
-            "❌ Invalid path \(path)"
+            "error: ❌ Invalid path \(path)"
         case .failedToResolveBuildableFolderPath(let path):
-            "❌ Failed to resolve buildable folder path \(path)"
+            "error: ❌ Failed to resolve buildable folder path \(path)"
         case .forbiddenBuildableFoldersForGroups(let groups):
-            "❌ Forbidden buildable folders for groups: \n\(groups.joined(separator: ", \n"))"
+            "error: ❌ Forbidden buildable folders for groups: \n\(groups.joined(separator: ", \n"))"
         case .exceptionSetTargetIsNil(let groupPath):
-            "❌ Exception set target is nil for group at path: \(groupPath)"
+            "error: ❌ Exception set target is nil for group at path: \(groupPath)"
         case .exceptionSetTargetProductTypeIsNil(let groupPath):
-            "❌ Exception set target product type is nil for group at path: \(groupPath)"
+            "error: ❌ Exception set target product type is nil for group at path: \(groupPath)"
         }
     }
 }

Sources/Exclusives/ExclusivesProcessor.swift

@@ -159,7 +159,7 @@ private extension ExclusivesProcessor {
         targets: String
     ) {
         guard !entries.isEmpty else { return }
-        print("Exclusive \(kind) found between targets \(targets):")
+        print("error: ❌ Exclusive \(kind) found between targets \(targets):")
         for entry in entries.sorted() {
             print(" - \(entry)")
         }

Tests/XcodeTargetsTests/Errors/DuplicatesErrorTests.swift

@@ -18,7 +18,7 @@ struct DuplicatesErrorTests {
         let description = error.description
 
         // Then
-        let expectedDescription = "❌ Duplicate testContext entries found:\nItem1, Item2, Item3"
+        let expectedDescription = "error: ❌ Duplicate testContext entries found:\nItem1, Item2, Item3"
         #expect(description == expectedDescription)
     }
 

Tests/XcodeTargetsTests/Errors/ExclusivesErrorTests.swift

@@ -13,7 +13,7 @@ struct ExclusivesErrorTests {
         let description = sut.description
 
         // Then
-        #expect(description == "❌ Target name MyTarget inside exclusive section doesn't exist in the project")
+        #expect(description == "error: ❌ Target name MyTarget inside exclusive section doesn't exist in the project")
     }
 
     @Test("test description of invalidPathForTarget")
@@ -25,7 +25,7 @@ struct ExclusivesErrorTests {
         let description = sut.description
 
         // Then
-        #expect(description == "❌ Path Sources/NonExistent inside exclusive section for target MyTarget doesn't exist in the project")
+        #expect(description == "error: ❌ Path Sources/NonExistent inside exclusive section for target MyTarget doesn't exist in the project")
     }
 
     @Test("test description of exclusiveEntriesFound")
@@ -37,6 +37,6 @@ struct ExclusivesErrorTests {
         let description = sut.description
 
         // Then
-        #expect(description == "❌ Exclusive entries found for targets: MyTarget1, MyTarget2")
+        #expect(description == "error: ❌ Exclusive entries found for targets: MyTarget1, MyTarget2")
     }
 }

Tests/XcodeTargetsTests/Errors/ForbiddenResourceErrorTests.swift

@@ -17,6 +17,6 @@ struct ForbiddenResourceErrorTests {
         let description = error.description
 
         // Then
-        #expect(description == "❌ Forbidden resource(s) found in target TargetA:\n - Sources/Forbidden/AnotherFile.swift\n - Sources/Forbidden/File.swift")
+        #expect(description == "error: ❌ Forbidden resource(s) found in target TargetA:\n - Sources/Forbidden/AnotherFile.swift\n - Sources/Forbidden/File.swift")
     }
 }

Tests/XcodeTargetsTests/Errors/XcodeProjectParserErrorTests.swift

@@ -14,7 +14,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        #expect(message == "❌ Invalid target name InvalidTarget")
+        #expect(message == "error: ❌ Invalid target name InvalidTarget")
     }
 
     @Test("test description with invalid path returns expected message")
@@ -27,7 +27,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        #expect(message == "❌ Invalid path Some/Invalid/Path")
+        #expect(message == "error: ❌ Invalid path Some/Invalid/Path")
     }
 
     @Test("test description with failed to resolve buildable folder path returns expected message")
@@ -40,7 +40,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        #expect(message == "❌ Failed to resolve buildable folder path Sources/Module/Buildable")
+        #expect(message == "error: ❌ Failed to resolve buildable folder path Sources/Module/Buildable")
     }
 
     @Test("test description with forbidden buildable folders for groups returns expected message")
@@ -53,7 +53,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        let expected = "❌ Forbidden buildable folders for groups: \nGroupA, \nGroupB, \nGroupC"
+        let expected = "error: ❌ Forbidden buildable folders for groups: \nGroupA, \nGroupB, \nGroupC"
         #expect(message == expected)
     }
 
@@ -67,7 +67,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        let expected = "❌ Forbidden buildable folders for groups: \n"
+        let expected = "error: ❌ Forbidden buildable folders for groups: \n"
         #expect(message == expected)
     }
 
@@ -81,7 +81,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        #expect(message == "❌ Exception set target is nil for group at path: Sources/Group/Path")
+        #expect(message == "error: ❌ Exception set target is nil for group at path: Sources/Group/Path")
     }
 
     @Test("test description with exception set target product type is nil returns expected message")
@@ -94,7 +94,7 @@ struct XcodeProjectParserErrorTests {
         let message = sut.description
 
         // Then
-        #expect(message == "❌ Exception set target product type is nil for group at path: Sources/Group/AnotherPath")
+        #expect(message == "error: ❌ Exception set target product type is nil for group at path: Sources/Group/AnotherPath")
     }
 
     // MARK: - Equatable