Update to go-1.26 (#20)

Author: majst01

.github/workflows/docker.yaml

@@ -21,7 +21,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
 
       - name: Setup Go
         uses: actions/setup-go@v6
@@ -30,7 +30,7 @@ jobs:
           cache: false
 
       - name: Lint
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           args: --build-tags integration --timeout=5m
 
@@ -58,7 +58,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
 
       - name: Setup Go
         uses: actions/setup-go@v6

Dockerfile

@@ -1,4 +1,4 @@
-FROM alpine:3.22
+FROM alpine:3.23
 LABEL maintainer="metal-stack authors <info@metal-stack.io>"
 COPY bin/metalctlv2-linux-amd64 /metalctl
 ENTRYPOINT ["/metalctl"]

cmd/admin/v2/image.go

@@ -146,7 +146,7 @@ func (c *image) Update(rq *adminv2.ImageServiceUpdateRequest) (*apiv2.Image, err
 
 	req := &adminv2.ImageServiceUpdateRequest{
 		Id:          viper.GetString("id"),
-		Url:         pointer.Pointer(viper.GetString("url")),
+		Url:         new(viper.GetString("url")),
 		Description: pointer.PointerOrNil(viper.GetString("description")),
 		ExpiresAt:   expiresAt,
 		Features:    imageFeaturesFromString(viper.GetStringSlice("features")),

cmd/admin/v2/tenant.go

@@ -69,7 +69,6 @@ func (c *tenant) List() ([]*apiv2.Tenant, error) {
 	req := &adminv2.TenantServiceListRequest{
 		Name:  pointer.PointerOrNil(viper.GetString("name")),
 		Login: pointer.PointerOrNil(viper.GetString("id")),
-		Email: pointer.PointerOrNil(viper.GetString("email")),
 	}
 
 	resp, err := c.c.Client.Adminv2().Tenant().List(ctx, req)

cmd/admin/v2/token.go

@@ -9,7 +9,6 @@ import (
 	"github.com/metal-stack/cli/cmd/sorters"
 	"github.com/metal-stack/metal-lib/pkg/genericcli"
 	"github.com/metal-stack/metal-lib/pkg/genericcli/printers"
-	"github.com/metal-stack/metal-lib/pkg/pointer"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 )
@@ -57,7 +56,7 @@ func (c *token) List() ([]*apiv2.Token, error) {
 	req := &adminv2.TokenServiceListRequest{}
 
 	if viper.IsSet("user") {
-		req.User = pointer.Pointer(viper.GetString("user"))
+		req.User = new(viper.GetString("user"))
 	}
 
 	resp, err := c.c.Client.Adminv2().Token().List(ctx, req)

cmd/api/v2/ip.go

@@ -9,7 +9,6 @@ import (
 	"github.com/metal-stack/cli/pkg/helpers"
 	"github.com/metal-stack/metal-lib/pkg/genericcli"
 	"github.com/metal-stack/metal-lib/pkg/genericcli/printers"
-	"github.com/metal-stack/metal-lib/pkg/pointer"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 )
@@ -70,11 +69,11 @@ func newIPCmd(c *config.Config) *cobra.Command {
 		CreateRequestFromCLI: func() (*apiv2.IPServiceCreateRequest, error) {
 			return &apiv2.IPServiceCreateRequest{
 				Project:     c.GetProject(),
-				Name:        pointer.Pointer(viper.GetString("name")),
-				Description: pointer.Pointer(viper.GetString("description")),
+				Name:        new(viper.GetString("name")),
+				Description: new(viper.GetString("description")),
 				Network:     viper.GetString("network"),
 				// Labels:        viper.GetStringSlice("tags"), // FIXME implement
-				Type:          pointer.Pointer(ipStaticToType(viper.GetBool("static"))),
+				Type:          new(ipStaticToType(viper.GetBool("static"))),
 				AddressFamily: addressFamilyToType(viper.GetString("addressfamily")),
 			}, nil
 		},

cmd/api/v2/project.go

@@ -228,8 +228,8 @@ func (c *project) Convert(r *apiv2.Project) (string, *apiv2.ProjectServiceCreate
 			Description: r.Description,
 		}, &apiv2.ProjectServiceUpdateRequest{
 			Project:     r.Uuid,
-			Name:        pointer.Pointer(r.Name),
-			Description: pointer.Pointer(r.Description),
+			Name:        new(r.Name),
+			Description: new(r.Description),
 		}, nil
 }
 

cmd/api/v2/token.go

@@ -85,7 +85,7 @@ func newTokenCmd(c *config.Config) *cobra.Command {
 					return nil, fmt.Errorf("unknown role: %s", roleString)
 				}
 
-				adminRole = pointer.Pointer(apiv2.AdminRole(role))
+				adminRole = new(apiv2.AdminRole(role))
 			}
 
 			return &apiv2.TokenServiceCreateRequest{

cmd/common_test.go

@@ -62,7 +62,6 @@ func (c *Test[R]) TestCmd(t *testing.T) {
 	}
 
 	for _, format := range outputFormats(c) {
-		format := format
 		t.Run(fmt.Sprintf("%v", format.Args()), func(t *testing.T) {
 			_, out, conf := c.newMockConfig(t)
 

cmd/config/config.go

@@ -44,7 +44,7 @@ func (c *Config) NewRequestContext() (context.Context, context.CancelFunc) {
 		timeout = pointer.Pointer(30 * time.Second)
 	}
 	if viper.IsSet("timeout") {
-		timeout = pointer.Pointer(viper.GetDuration("timeout"))
+		timeout = new(viper.GetDuration("timeout"))
 	}
 
 	return context.WithTimeout(context.Background(), *timeout)