PHP 8.4 compatibility (#222)

ruudk · web-flow · commit 47e765211f0c · 2024-11-01T16:58:18.000+01:00
* Add PHP 8.3 and PHP 8.4 to matrix

* Make compatible with PHP 8.4

&gt; MessageBird\Client::__construct(): Implicitly marking parameter $httpClient as nullable is deprecated, the explicit nullable type must be used instead
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [ '7.4', '8.0', '8.1', '8.2' ]
+        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         stability: [ prefer-stable ]
 
     name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
diff --git a/src/MessageBird/Client.php b/src/MessageBird/Client.php
@@ -147,7 +147,7 @@ class Client
      */
     protected $numbersAPIClient;
 
-    public function __construct(?string $accessKey = null, Common\HttpClient $httpClient = null, array $config = [])
+    public function __construct(?string $accessKey = null, ?Common\HttpClient $httpClient = null, array $config = [])
     {
         if ($httpClient === null) {
             $this->conversationsAPIHttpClient = new Common\HttpClient(

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ class Client`
`147`	`147`	`*/`
`148`	`148`	`protected $numbersAPIClient;`
`149`	`149`
`150`		`- public function __construct(?string $accessKey = null, Common\HttpClient $httpClient = null, array $config = [])`
	`150`	`+ public function __construct(?string $accessKey = null, ?Common\HttpClient $httpClient = null, array $config = [])`
`151`	`151`	`{`
`152`	`152`	`if ($httpClient === null) {`
`153`	`153`	`$this->conversationsAPIHttpClient = new Common\HttpClient(`