Skip to content

Commit 4361e9a

Browse files
authored
Fix jest ts-jest config warning (jpmorganchase#2281)
* Fix jest ts-jest config warning * changeset
1 parent 6a11aeb commit 4361e9a

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

.changeset/hot-goats-sleep.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'modular-scripts': patch
3+
---
4+
5+
Fixed configuration of ts-jest under `globals` deprecated warning

packages/modular-scripts/src/test/config.ts

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,13 @@ export function createJestConfig(
5858
presets: [require.resolve('babel-preset-react-app')],
5959
},
6060
],
61-
'^.+\\.(ts|tsx)$': require.resolve('ts-jest'),
61+
// don't typecheck tests in CI
62+
'^.+\\.(ts|tsx)$': isCi
63+
? [
64+
require.resolve('ts-jest'),
65+
{ diagnostics: false, isolatedModules: true },
66+
]
67+
: require.resolve('ts-jest'),
6268
'^.+\\.(css|scss)$': require.resolve('jest-transform-stub'),
6369
'.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$':
6470
require.resolve('jest-transform-stub'),
@@ -199,15 +205,5 @@ export function createJestConfig(
199205
});
200206
}
201207

202-
// don't typecheck tests in CI
203-
if (isCi) {
204-
jestConfig.globals = {
205-
'ts-jest': {
206-
diagnostics: false,
207-
isolatedModules: true,
208-
},
209-
};
210-
}
211-
212208
return jestConfig;
213209
}

0 commit comments

Comments
 (0)