Process feedback

Author: McDoyen

.travis.yml

@@ -1,13 +1,7 @@
 sudo: required
 language: node_js
 node_js:
-- "8"
-addons:
-  apt:
-    sources:
-    - google-chrome
-    packages:
-    - google-chrome-stable
+- "8.10.0"
 before_install:
 - npm i -g npm
 - npm install grunt-cli -g

README.md

@@ -5,7 +5,7 @@
 ![badge](https://img.shields.io/badge/mendix-7.14.1-green.svg)
 
 # Dropdown
-An input widget used to display and edit associations
+An input widget used to display and edit associations for reference and reference sets
 
 ## Features
 * Search for matching options
@@ -25,32 +25,32 @@ An input widget used to display and edit associations
 Mendix 7.13.1
 
 ## Demo project
-[https://dropdowntypeahead.mxapps.io]( https://dropdowntypeahead.mxapps.io)
+[https://dropdowntypeahead.mxapps.io](https://dropdowntypeahead.mxapps.io)
 
 ## Usage
 ![dropdown-type-ahead](/assets/dropdown-typeahead-normal-loading.gif)
 
-* Place the widget in data form within the context of an entity 
+* Place the widget in data form within the context of an entity
 * Select entity path and attribute over reference for selectable objects
 * Select the data source
 
 ## Basic configuration
 For a basic configuration, set up the widget as indicated below:-
 ### Data source
 ![dropdown-typeahead-data-source](/assets/dropdown-typeahead-data-source.png)
-### Appearance  
-![dropdown-typeahead-appearance](/assets/dropdown-typeahead-appearance.png)  
+### Appearance
+![dropdown-typeahead-appearance](/assets/dropdown-typeahead-appearance.png)
 ### Label
-![dropdown-typeahead-label](/assets/dropdown-typeahead-label.png)  
+![dropdown-typeahead-label](/assets/dropdown-typeahead-label.png)
 ### Selectable objects
-![dropdown-typeahead-selectable-objects](/assets/dropdown-typeahead-selectable.png)  
+![dropdown-typeahead-selectable-objects](/assets/dropdown-typeahead-selectable.png)
 ### Search
-![dropdown-typeahead-search](/assets/dropdown-typeahead-search.png)  
+![dropdown-typeahead-search](/assets/dropdown-typeahead-search.png)
 ### Events
 ![dropdown-typeahead-events](/assets/dropdown-typeahead-events.png)
 
 ## Issues, suggestions and feature requests
-We are actively maintaining this widget, please report any issues or suggestion for improvement at  
+We are actively maintaining this widget, please report any issues or suggestion for improvement at
 https://github.com/mendixlabs/dropdown-type-ahead/issues
 
 ## Development and contribution

package-lock.json

@@ -6,7 +6,7 @@
   "copyright": "Mendix BV",
   "scripts": {
     "start": "webpack-dev-server --hot --open",
-    "emit": "tsc",
+    "typeCheck": "tsc --noEmit",
     "pretest": "tsc && npm run lint && npm run build",
     "test": "npm run test:unit && npm run test:conditional",
     "test:conditional": "node ./node_modules/mendix-widget-build-script/dist/CheckPullRequestFromFork.js && echo 'Skip tests on forked pull request' || npm run deployAndTest",
@@ -27,7 +27,7 @@
     "developmentPort": 3000
   },
   "pre-commit": [
-    "emit",
+    "typeCheck",
     "lint"
   ],
   "repository": {
@@ -43,16 +43,16 @@
     "@types/core-js": "^2.5.0",
     "@types/enzyme": "^3.1.15",
     "@types/enzyme-adapter-react-16": "^1.0.2",
-    "@types/jasmine": "^3.3.0",
+    "@types/jasmine": "^3.3.1",
     "@types/karma": "^3.0.1",
-    "@types/node": "^10.12.11",
-    "@types/react": "^16.7.10",
+    "@types/node": "^10.12.12",
+    "@types/react": "^16.7.13",
     "@types/react-dom": "^16.0.11",
     "@types/react-select": "^1.3.0",
     "@types/webdriverio": "^4.13.0",
     "check-dependencies": "^1.0.1",
     "copy-webpack-plugin": "^4.6.0",
-    "core-js": "^2.5.7",
+    "core-js": "^2.6.0",
     "css-loader": "^1.0.1",
     "enzyme": "^3.7.0",
     "enzyme-adapter-react-16": "^1.7.0",
@@ -69,7 +69,7 @@
     "grunt-webpack": "^3.1.3",
     "istanbul": "^0.4.3",
     "istanbul-instrumenter-loader": "^3.0.1",
-    "jasmine": "^3.3.0",
+    "jasmine": "^3.3.1",
     "karma": "^3.1.3",
     "karma-chrome-launcher": "^2.1.1",
     "karma-coverage": "^1.1.2",
@@ -102,7 +102,7 @@
     "wdio-selenium-standalone-service": "0.0.11",
     "wdio-spec-reporter": "^0.1.3",
     "webdriverio": "^4.14.1",
-    "webpack": "^4.26.1",
+    "webpack": "^4.27.1",
     "webpack-bundle-analyzer": "^3.0.3",
     "webpack-cli": "^3.1.2",
     "webpack-dev-server": "^3.1.10",

package.json

@@ -34,9 +34,9 @@ export class preview extends Component<ContainerProps, {}> {
             readOnlyStyle: this.props.readOnlyStyle,
             lazyFilter: this.props.lazyFilter,
             selectedValue,
-            searchText: this.props.searchText,
             loadingText: this.props.loadingText,
             minimumCharacter: this.props.minimumCharacter,
+            searchPromptText: this.props.searchPromptText,
             showLabel: this.props.showLabel,
             styleObject: parseStyle(this.props.style)
         });

src/DropdownReference/DropdownReference.webmodeler.ts

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <widget id="com.mendix.widget.custom.dropdown.DropdownReference" needsEntityContext="true" offlineCapable="true" xmlns="http://www.mendix.com/widget/1.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.mendix.com/widget/1.0/ ../../../../../xsd/widget.xsd">
     <name>Dropdown reference</name>
-    <description/>
+    <description>An input widget used to display and edit associations for reference</description>
     <icon></icon>
     <properties>
         <property key="entityPath" type="entity" isPath="yes" pathType="reference">
@@ -36,6 +36,10 @@
             <caption>Empty caption</caption>
             <category>Appearance</category>
             <description>Text displayed when no selection is made</description>
+            <translations>
+                <translation lang="en_US">(no option selected)</translation>
+                <translation lang="nl_NL">(geen option selecteerd)</translation>
+            </translations>
         </property>
         <property key="readOnlyStyle" type="enumeration" defaultValue="control">
             <caption>Read-only style</caption>
@@ -115,7 +119,7 @@
         <property key="sortAttributes" type="object" isList="true" required="false">
             <caption>Sort order</caption>
             <category>Selectable objects</category>
-            <description></description>
+            <description>Sorting only applies to source 'Database'</description>
             <properties>
                 <property key="name" type="attribute" required="false" isPath="optional" pathType="reference" entityProperty="../entityPath">
                     <caption>Attribute</caption>
@@ -158,11 +162,6 @@
             <category>Selectable objects</category>
             <description>Attribute set with search text of the user, this could be used for filter results in microflow or nanoflow</description>
             <attributeTypes>
-                <attributeType name="AutoNumber"/>
-                <attributeType name="Enum"/>
-                <attributeType name="Decimal"/>
-                <attributeType name="Integer"/>
-                <attributeType name="Long"/>
                 <attributeType name="String"/>
             </attributeTypes>
         </property>
@@ -189,6 +188,15 @@
             <category>Selectable objects</category>
             <description>Number of characters typed before an initial search is triggered</description>
         </property>
+        <property key="searchPromptText" type="translatableString" required="false">
+            <caption>Search prompt text</caption>
+            <category>Selectable objects</category>
+            <description>Text to display on dropdown before typing</description>
+            <translations>
+                <translation lang="en_US">Type to search</translation>
+                <translation lang="nl_NL">Type om te zoeken</translation>
+            </translations>
+        </property>
         <property key="onChangeEvent" type="enumeration" defaultValue="doNothing">
             <caption>On change</caption>
             <category>Events</category>