From f4d1bb5bd2b26bffc516994a593eb1389304edb7 Mon Sep 17 00:00:00 2001 From: Roman Vyakhirev Date: Thu, 2 Apr 2026 16:54:00 +0200 Subject: [PATCH 1/2] feat: introduce maker for popup/dropdowns in data widgets components --- .../combobox-web/src/components/ComboboxMenuWrapper.tsx | 1 + .../src/components/DatePicker.tsx | 1 + .../datagrid-web/src/components/ColumnSelector.tsx | 1 + .../src/__tests__/__snapshots__/Menu.spec.tsx.snap | 1 + .../src/__tests__/__snapshots__/PopupMenu.spec.tsx.snap | 1 + .../popup-menu-web/src/components/Menu.tsx | 1 + .../tooltip-web/src/components/Tooltip.tsx | 1 + .../__tests__/__snapshots__/Tooltip.spec.tsx.snap | 1 + .../src/controls/base/OptionsWrapper.tsx | 8 +++++++- .../src/controls/filter-selector/FilterSelector.tsx | 1 + 10 files changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/pluggableWidgets/combobox-web/src/components/ComboboxMenuWrapper.tsx b/packages/pluggableWidgets/combobox-web/src/components/ComboboxMenuWrapper.tsx index cda1155f9a..51f414c827 100644 --- a/packages/pluggableWidgets/combobox-web/src/components/ComboboxMenuWrapper.tsx +++ b/packages/pluggableWidgets/combobox-web/src/components/ComboboxMenuWrapper.tsx @@ -61,6 +61,7 @@ export function ComboboxMenuWrapper(props: ComboboxMenuWrapperProps): ReactEleme } : style } + data-overlay-content={isOpen || undefined} > {menuHeaderContent && (
(props.expanded ?
{children}
: null)} allowSameDay={false} ariaLabelledBy={`${props.id}-label`} autoFocus={false} diff --git a/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx b/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx index caac97e39c..9ec931e44b 100644 --- a/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx +++ b/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx @@ -125,6 +125,7 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement { id={`${props.id}-column-selectors`} className={`column-selectors`} data-focusindex={0} + data-overlay-content role="menu" style={{ ...correctedFloatingStyles, maxHeight }} {...getFloatingProps()} diff --git a/packages/pluggableWidgets/popup-menu-web/src/__tests__/__snapshots__/Menu.spec.tsx.snap b/packages/pluggableWidgets/popup-menu-web/src/__tests__/__snapshots__/Menu.spec.tsx.snap index d2eb16172f..cecd9fde46 100644 --- a/packages/pluggableWidgets/popup-menu-web/src/__tests__/__snapshots__/Menu.spec.tsx.snap +++ b/packages/pluggableWidgets/popup-menu-web/src/__tests__/__snapshots__/Menu.spec.tsx.snap @@ -17,6 +17,7 @@ exports[`Menu renders menu 1`] = ` diff --git a/packages/pluggableWidgets/tooltip-web/src/components/Tooltip.tsx b/packages/pluggableWidgets/tooltip-web/src/components/Tooltip.tsx index 13637494c6..231885c1c3 100644 --- a/packages/pluggableWidgets/tooltip-web/src/components/Tooltip.tsx +++ b/packages/pluggableWidgets/tooltip-web/src/components/Tooltip.tsx @@ -48,6 +48,7 @@ export const Tooltip = (props: TooltipProps): ReactElement => { ref={refs?.setFloating} style={floatingStyles} {...getFloatingProps?.()} + data-overlay-content > {renderMethod === "text" ? textMessage : htmlMessage}
diff --git a/packages/pluggableWidgets/tooltip-web/src/components/__tests__/__snapshots__/Tooltip.spec.tsx.snap b/packages/pluggableWidgets/tooltip-web/src/components/__tests__/__snapshots__/Tooltip.spec.tsx.snap index 21d786034a..0c48903965 100644 --- a/packages/pluggableWidgets/tooltip-web/src/components/__tests__/__snapshots__/Tooltip.spec.tsx.snap +++ b/packages/pluggableWidgets/tooltip-web/src/components/__tests__/__snapshots__/Tooltip.spec.tsx.snap @@ -19,6 +19,7 @@ exports[`Tooltip render DOM structure 1`] = `