Merge branch 'megaeth-labs:main' into main

Author: KENILSHAHH

.github/workflows/claude.yml

@@ -77,7 +77,7 @@ jobs:
           additional_permissions: |
             actions: read
           claude_args: |
-            --allowedTools "Read,Glob,Grep,mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr checks:*),Bash(gh label list:*),Bash(gh run view:*),Bash(gh run list:*),Bash(git log:*),Bash(git diff:*),Bash(git show:*),Bash(git blame:*),Bash(git status:*),Bash(ls:*),Bash(tree:*)"
+            --allowedTools "Read,Glob,Grep,mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr checks:*),Bash(gh label list:*),Bash(gh run view:*),Bash(gh run list:*),Bash(gh api:*),Bash(git log:*),Bash(git diff:*),Bash(git show:*),Bash(git blame:*),Bash(git status:*),Bash(ls:*),Bash(tree:*)"
           prompt: |
             REPO: ${{ github.repository }}
             PR NUMBER: ${{ github.event.pull_request.number }}

REVIEW.md

@@ -19,6 +19,15 @@
 - No high-cardinality labels (no tx hashes or addresses as label values)
 - Prometheus naming conventions: `snake_case` with unit suffixes (`_seconds`, `_bytes`, `_total`)
 
+## Previous comments
+
+- Before writing new comments, check all previous review threads on this PR
+- If a previous comment has been addressed by the latest changes, resolve that thread using:
+  `gh api graphql -f query='mutation { resolveReviewThread(input:{threadId:"THREAD_ID"}) { thread { id } } }'`
+- To find thread IDs, query:
+  `gh api graphql -f query='{ repository(owner:"OWNER", name:"REPO") { pullRequest(number:NUMBER) { reviewThreads(first:50) { nodes { id isResolved comments(first:1) { nodes { body path } } } } } } }'`
+- Do not repeat feedback that has already been addressed
+
 ## Skip
 
 - Formatting-only changes already enforced by `cargo fmt`

bin/stateless-validator/src/metrics.rs

@@ -97,6 +97,7 @@ pub fn init_metrics(addr: SocketAddr) -> Result<()> {
         .map_err(|e| eyre::eyre!("Failed to install Prometheus exporter: {}", e))?;
 
     register_metric_descriptions();
+    init_rpc_method_counters();
     info!("[Metrics] Prometheus exporter listening on {}", addr);
     Ok(())
 }
@@ -145,6 +146,24 @@ fn register_metric_descriptions() {
     describe_histogram!(names::SALT_WITNESS_KVS_SIZE, "Salt witness KVs size (bytes)");
 }
 
+/// Pre-register RPC method counters used by the validator so they appear in Prometheus output from
+/// startup.
+fn init_rpc_method_counters() {
+    let methods = [
+        RpcMethod::EthGetCodeByHash,
+        RpcMethod::EthGetBlockByNumber,
+        RpcMethod::EthBlockNumber,
+        RpcMethod::EthGetHeader,
+        RpcMethod::MegaGetBlockWitness,
+        RpcMethod::MegaSetValidatedBlocks,
+    ];
+    for method in methods {
+        let method_str = method.as_str();
+        counter!(names::RPC_REQUESTS_TOTAL, "method" => method_str).increment(0);
+        counter!(names::RPC_ERRORS_TOTAL, "method" => method_str).increment(0);
+    }
+}
+
 /// Record validation timing and block statistics after successful validation.
 #[allow(clippy::too_many_arguments)]
 pub fn on_validation_success(