Skip to content

Commit b80ecb6

Browse files
committed
ci: pin windows workspace leg back to mcpp 0.0.94 (temporary, mcpp#230)
mcpp 0.0.95 aborts `mcpp test --workspace` with exit 127 on windows-latest (regression tracked in mcpp-community/mcpp#230; main@0.0.94 is green daily). Windows consumes no 0.0.95 descriptor grammar — the compat.ffmpeg member is cfg(linux)-gated to a no-op there — so the older floor is sound. The pin is a per-matrix override (MCPP_EFFECTIVE); drop it once #230 is fixed.
1 parent cba30b6 commit b80ecb6

1 file changed

Lines changed: 17 additions & 7 deletions

File tree

.github/workflows/validate.yml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,14 @@ jobs:
168168
ext: zip
169169
mcpp: bin/mcpp.exe
170170
xlings: registry/bin/xlings.exe
171+
# TEMPORARY: pinned back to 0.0.94 — mcpp 0.0.95 aborts
172+
# `mcpp test --workspace` with exit 127 on windows-latest
173+
# (mcpp-community/mcpp#230). This platform consumes no 0.0.95
174+
# descriptor grammar (cfg(linux)-gated members are no-ops here),
175+
# so the older floor is sound. Drop once #230 is fixed.
176+
mcpp_version: "0.0.94"
177+
env:
178+
MCPP_EFFECTIVE: ${{ matrix.mcpp_version || env.MCPP_VERSION }}
171179
steps:
172180
- uses: actions/checkout@v4
173181
- name: Restore mcpp registry cache
@@ -176,17 +184,17 @@ jobs:
176184
# Holds toolchains AND the built compat packages (data/xpkgs), so a
177185
# repeat `mcpp test` rebuilds little.
178186
path: ~/.mcpp/registry
179-
key: mcpp-registry-${{ runner.os }}-${{ env.MCPP_VERSION }}-${{ hashFiles('pkgs/**/*.lua', 'tests/**', '.github/workflows/validate.yml') }}
187+
key: mcpp-registry-${{ runner.os }}-${{ env.MCPP_EFFECTIVE }}-${{ hashFiles('pkgs/**/*.lua', 'tests/**', '.github/workflows/validate.yml') }}
180188
restore-keys: |
181-
mcpp-registry-${{ runner.os }}-${{ env.MCPP_VERSION }}-
189+
mcpp-registry-${{ runner.os }}-${{ env.MCPP_EFFECTIVE }}-
182190
- name: Download mcpp
183191
shell: bash
184192
env:
185-
MCPP_ARCHIVE: mcpp-${{ env.MCPP_VERSION }}-${{ matrix.suffix }}.${{ matrix.ext }}
186-
MCPP_ROOT: mcpp-${{ env.MCPP_VERSION }}-${{ matrix.suffix }}
193+
MCPP_ARCHIVE: mcpp-${{ env.MCPP_EFFECTIVE }}-${{ matrix.suffix }}.${{ matrix.ext }}
194+
MCPP_ROOT: mcpp-${{ env.MCPP_EFFECTIVE }}-${{ matrix.suffix }}
187195
run: |
188196
curl -L -fsS -o "$MCPP_ARCHIVE" \
189-
"https://github.com/mcpp-community/mcpp/releases/download/v${MCPP_VERSION}/${MCPP_ARCHIVE}"
197+
"https://github.com/mcpp-community/mcpp/releases/download/v${MCPP_EFFECTIVE}/${MCPP_ARCHIVE}"
190198
case "$MCPP_ARCHIVE" in
191199
*.zip) powershell -NoProfile -Command "Expand-Archive -Force -Path '${MCPP_ARCHIVE}' -DestinationPath '.'" ;;
192200
*) tar -xzf "$MCPP_ARCHIVE" ;;
@@ -233,15 +241,17 @@ jobs:
233241
imgui-module:
234242
runs-on: ubuntu-latest
235243
timeout-minutes: 60
244+
env:
245+
MCPP_EFFECTIVE: ${{ matrix.mcpp_version || env.MCPP_VERSION }}
236246
steps:
237247
- uses: actions/checkout@v4
238248
- name: Restore mcpp registry cache
239249
uses: actions/cache@v4
240250
with:
241251
path: ~/.mcpp/registry
242-
key: mcpp-registry-${{ runner.os }}-${{ env.MCPP_VERSION }}-${{ hashFiles('pkgs/**/*.lua', 'tests/**', '.github/workflows/validate.yml') }}
252+
key: mcpp-registry-${{ runner.os }}-${{ env.MCPP_EFFECTIVE }}-${{ hashFiles('pkgs/**/*.lua', 'tests/**', '.github/workflows/validate.yml') }}
243253
restore-keys: |
244-
mcpp-registry-${{ runner.os }}-${{ env.MCPP_VERSION }}-
254+
mcpp-registry-${{ runner.os }}-${{ env.MCPP_EFFECTIVE }}-
245255
- name: Download mcpp
246256
run: |
247257
curl -L -fsS -o mcpp.tar.gz \

0 commit comments

Comments
 (0)