fix(matchers): loosed DictMatching types to accept any key type (#296)

Author: mcous

decoy/matchers.py

@@ -28,8 +28,7 @@ def test_logger_called(decoy: Decoy):
 """
 
 from re import compile as compile_re
-from typing import cast, Any, List, Mapping, Optional, Pattern, Type, TypeVar
-
+from typing import Any, List, Mapping, Optional, Pattern, Type, TypeVar, cast
 
 __all__ = [
     "Anything",
@@ -212,9 +211,9 @@ class HelloWorld:
 
 
 class _DictMatching:
-    _values: Mapping[str, Any]
+    _values: Mapping[Any, Any]
 
-    def __init__(self, values: Mapping[str, Any]) -> None:
+    def __init__(self, values: Mapping[Any, Any]) -> None:
         self._values = values
 
     def __eq__(self, target: object) -> bool:
@@ -235,7 +234,7 @@ def __repr__(self) -> str:
         return f"<DictMatching {self._values!r}>"
 
 
-def DictMatching(values: Mapping[str, Any]) -> Any:
+def DictMatching(values: Mapping[Any, Any]) -> Any:
     """Match any dictionary with the passed in keys / values.
 
     Arguments:

tests/test_matchers.py

@@ -1,9 +1,12 @@
 """Matcher tests."""
 
-import pytest
 from collections import namedtuple
-from decoy import Decoy, matchers
 from typing import Any, List, NamedTuple
+
+import pytest
+
+from decoy import Decoy, matchers
+
 from .fixtures import SomeClass
 
 
@@ -91,7 +94,7 @@ def test_has_attribute_matcher() -> None:
 
 
 def test_dict_matching_matcher() -> None:
-    """It should have an "anything with these attributes" matcher."""
+    """It should have a "dictionary matching" matcher."""
     assert {"hello": "world"} == matchers.DictMatching({"hello": "world"})
     assert {"hello": "world", "goodbye": "so long"} == matchers.DictMatching(
         {"hello": "world"}
@@ -106,6 +109,11 @@ def test_dict_matching_matcher() -> None:
     assert [] != matchers.DictMatching({"hello": "world"})
 
 
+def test_dict_matching_matcher_with_int_key() -> None:
+    """Dict matcher should suport non-string keys."""
+    assert {1: "hello", 2: "world"} == matchers.DictMatching({2: "world"})
+
+
 def test_list_matching_matcher() -> None:
     """It should have a "contains this sub-list" matcher."""
     assert [1, 2, 3] == matchers.ListMatching([1])