The git rev-parse --short HEAD below resolves to Git hash
|
VERSION ?= $(shell git rev-parse --short HEAD) |
|
DOCKER_TAG ?= mccutchen/go-httpbin:$(VERSION) |
Shouldn't the VERSION be based on Git tag, that is, git describe --tags --abbrev=0?
This makes me wonder, is this VERSION actually used for the image tagging?
Perhaps Docker images are tagged following this instruction?
|
Use `VERSION` to override the tag value |
|
|
|
make imagepush VERSION=v1.2.3 |
If my understanding is correct and there is room for improvement indeed, I can propose PR.
The
git rev-parse --short HEADbelow resolves to Git hashgo-httpbin/Makefile
Lines 3 to 4 in 34a21a3
Shouldn't the
VERSIONbe based on Git tag, that is,git describe --tags --abbrev=0?This makes me wonder, is this
VERSIONactually used for the image tagging?Perhaps Docker images are tagged following this instruction?
go-httpbin/DEVELOPMENT.md
Lines 93 to 95 in 34a21a3
If my understanding is correct and there is room for improvement indeed, I can propose PR.