Only show later-today delays if they are single tracking

Author: jlucytan

lib/dotcom/system_status.ex

@@ -5,7 +5,7 @@ defmodule Dotcom.SystemStatus do
   or whether there are alerts that impact service.
   """
 
-  import Dotcom.Alerts, only: [service_impacting_alert?: 1]
+  import Dotcom.Alerts, only: [in_effect_now?: 1, service_impacting_alert?: 1]
 
   alias Dotcom.SystemStatus
 
@@ -19,13 +19,18 @@ defmodule Dotcom.SystemStatus do
   def subway_status() do
     @alerts_repo.by_route_types([0, 1], @date_time_module.now())
     |> Enum.filter(&status_alert?(&1, @date_time_module.now()))
+    |> Enum.filter(&active_now_or_single_tracking?(&1))
     |> SystemStatus.Subway.subway_status(@date_time_module.now())
   end
 
   def status_alert?(alert, datetime) do
     service_impacting_alert?(alert) and active_now_or_later_on_day?(alert, datetime)
   end
 
+  defp active_now_or_single_tracking?(alert) do
+    alert.cause == :single_tracking or in_effect_now?(alert)
+  end
+
   @doc """
   Returns `true` if the alert is active at some point during the day
   given, unless the alert's end time is before the time given.

test/dotcom/system_status_test.exs

@@ -51,6 +51,29 @@ defmodule Dotcom.SystemStatusTest do
 
       assert non_normal_status == currently_active_alert.effect
     end
+
+    test "returns status without alerts beginning later that day unless they are single-tracking" do
+      route_id_with_alerts = Dotcom.Routes.subway_route_ids() |> Faker.Util.pick()
+      line = Dotcom.Routes.line_name_for_subway_route(route_id_with_alerts)
+      {day_start, day_end} = service_range_day()
+      later_start = Timex.shift(day_start, hours: 5)
+      currently_active_alert = disruption_alert({day_start, day_end}, route_id_with_alerts)
+      later_alert = disruption_alert({later_start, day_end}, route_id_with_alerts)
+      single_tracking_alert = disruption_alert({later_start, day_end}, route_id_with_alerts, :single_tracking)
+
+      expect(Alerts.Repo.Mock, :by_route_types, fn [0, 1], _date ->
+        [currently_active_alert, later_alert, single_tracking_alert]
+      end)
+
+      assert %{^line => statuses} = subway_status()
+
+      assert %{alerts: [^currently_active_alert, ^single_tracking_alert], status: non_normal_status} =
+               Enum.find_value(statuses, fn %{status_entries: status_entries} ->
+                 Enum.find(status_entries, &(&1.status != :normal))
+               end)
+
+      assert non_normal_status == currently_active_alert.effect
+    end
   end
 
   describe "active_now_or_later_on_day?/2" do
@@ -201,4 +224,16 @@ defmodule Dotcom.SystemStatusTest do
       severity: random_severity
     )
   end
+
+  defp disruption_alert(active_period, route_id, cause) do
+    {random_effect, random_severity} = service_impacting_effects() |> Faker.Util.pick()
+
+    build(:alert_for_route,
+      route_id: route_id,
+      active_period: [active_period],
+      effect: random_effect,
+      severity: random_severity,
+      cause: cause
+    )
+  end
 end