Fixed flaky tests due to duplicate random data being generated

Author: mbcrawfo

tests/KnowledgeBaseServer.Tests/Data/Topic.cs

@@ -18,7 +18,7 @@ public static Faker<Topic> Faker() =>
         new Faker<Topic>()
             .RuleFor(x => x.Id, Guid.CreateVersion7)
             .RuleFor(x => x.Created, f => f.Date.PastOffset())
-            .RuleFor(x => x.Name, f => f.Lorem.Sentence(3));
+            .RuleFor(x => x.Name, f => f.Lorem.Sentence());
 }
 
 public static partial class DbConnectionExtensions

tests/KnowledgeBaseServer.Tests/FakerExtensions.cs

@@ -0,0 +1,53 @@
+using System;
+using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Linq;
+using Bogus;
+
+namespace KnowledgeBaseServer.Tests;
+
+public static class FakerExtensions
+{
+    public static IEnumerable<T> MakeUnique<T>(this Faker faker, Func<Faker, T> generator)
+    {
+        return CreateItems().Distinct();
+
+        [SuppressMessage(
+            "Blocker Bug",
+            "S2190:Loops and recursions should not be infinite",
+            Justification = "The method is intended to generate a potentially infinite sequence of items..."
+        )]
+        IEnumerable<T> CreateItems()
+        {
+            while (true)
+            {
+                yield return generator(faker);
+            }
+            // ReSharper disable once IteratorNeverReturns
+        }
+    }
+
+    public static IEnumerable<TItem> MakeUnique<TItem, TProperty>(
+        this Faker faker,
+        Func<Faker, TItem> generator,
+        Func<TItem, TProperty> uniquePropertySelector
+    )
+        where TProperty : notnull
+    {
+        return CreateItems().DistinctBy(uniquePropertySelector);
+
+        [SuppressMessage(
+            "Blocker Bug",
+            "S2190:Loops and recursions should not be infinite",
+            Justification = "The method is intended to generate a potentially infinite sequence of items."
+        )]
+        IEnumerable<TItem> CreateItems()
+        {
+            while (true)
+            {
+                yield return generator(faker);
+            }
+            // ReSharper disable once IteratorNeverReturns
+        }
+    }
+}

tests/KnowledgeBaseServer.Tests/Tools/SearchMemoryToolTests.cs

@@ -83,7 +83,7 @@ public void ShouldReturnMemoryMatchingPhrases()
     public void ShouldFilterMatchingMemoriesByTopic_WhenTopicsAreProvided()
     {
         // arrange
-        var topics = _faker.Lorem.Words();
+        var topics = _faker.MakeUnique(f => f.Lorem.Word()).Take(3).ToArray();
         var searchPhrase = _faker.Lorem.Word();
 
         foreach (var topic in topics)
@@ -266,7 +266,7 @@ public void ShouldReturnOnlyNonOutdatedMemories_WhenExcludingOutdated()
     public void ShouldFilterResults_WhenFilteringByTopicAndExcludingOutdated()
     {
         // arrange
-        var topics = _faker.Lorem.Words();
+        var topics = _faker.MakeUnique(f => f.Lorem.Word()).Take(3).ToArray();
         var searchPhrase = _faker.Lorem.Word();
         var memoryIdsByTopic = new Dictionary<string, List<Guid>>();