Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=petrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

Author: matthiaskrgr

compiler/rustc_middle/src/ty/vtable.rs

@@ -99,9 +99,10 @@ pub(super) fn vtable_allocation_provider<'tcx>(
     // This confirms that the layout computation for &dyn Trait has an accurate sizing.
     assert!(vtable_entries.len() >= vtable_min_entries(tcx, poly_trait_ref));
 
-    let layout = tcx
-        .layout_of(ty::TypingEnv::fully_monomorphized().as_query_input(ty))
-        .expect("failed to build vtable representation");
+    let layout = match tcx.layout_of(ty::TypingEnv::fully_monomorphized().as_query_input(ty)) {
+        Ok(layout) => layout,
+        Err(e) => tcx.dcx().emit_fatal(e.into_diagnostic()),
+    };
     assert!(layout.is_sized(), "can't create a vtable for an unsized type");
     let size = layout.size.bytes();
     let align = layout.align.bytes();

tests/ui/limits/vtable-try-as-dyn.debuginfo.stderr

@@ -0,0 +1,4 @@
+error: values of the type `[u8; usize::MAX]` are too big for the target architecture
+
+error: aborting due to 1 previous error
+

tests/ui/limits/vtable-try-as-dyn.default.stderr

@@ -0,0 +1,4 @@
+error: values of the type `[u8; usize::MAX]` are too big for the target architecture
+
+error: aborting due to 1 previous error
+

tests/ui/limits/vtable-try-as-dyn.rs

@@ -0,0 +1,14 @@
+// At the time of writing, vtable.rs would ICE only with debuginfo disabled, while this testcase,
+// originally reported as #152030, would ICE even with debuginfo enabled.
+//@ revisions: default debuginfo
+//@ compile-flags: --crate-type=lib --emit=mir
+//@[debuginfo] compile-flags: -C debuginfo=2
+#![feature(try_as_dyn)]
+
+trait Trait {}
+impl<T> Trait for T {}
+
+//~? ERROR: values of the type `[u8; usize::MAX]` are too big for the target architecture
+pub fn foo(x: &[u8; usize::MAX]) {
+    let _ = std::any::try_as_dyn::<[u8; usize::MAX], dyn Trait>(x);
+}

tests/ui/limits/vtable.rs

@@ -0,0 +1,8 @@
+//@ compile-flags: --crate-type=lib --emit=mir
+pub trait Trait {}
+impl<T> Trait for T {}
+
+//~? ERROR: values of the type `[u8; usize::MAX]` are too big for the target architecture
+pub fn foo(x: &[u8; usize::MAX]) -> &dyn Trait {
+    x as &dyn Trait
+}

tests/ui/limits/vtable.stderr

@@ -0,0 +1,4 @@
+error: values of the type `[u8; usize::MAX]` are too big for the target architecture
+
+error: aborting due to 1 previous error
+