Merge pull request #1054 from marklogic/revert_new_optic_changes

MLE-12345: revert new optic changes

Author: stevebio

lib/plan-builder-base.js

@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2015-2026 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
+* Copyright (c) 2015-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
 */
 'use strict';
 
@@ -58,11 +58,8 @@ function castArg(arg, funcName, paramName, argPos, paramTypes) {
     } else if (arg instanceof Number || arg instanceof Boolean || arg instanceof String) {
       arg = arg.valueOf();
     } else if (arg instanceof types.ServerType) {
-      // We added new VecVector ServerType which is not a sub-type of Item. This makes it a one-off type
-      // as paramTypes will not include VecVector in any other type checks.
-      // And if we get here the arg must be and only be a VecVector (arg._ns === 'vec') or we throw an Error      
       if(arg._ns === 'vec'){
-        return arg;
+        return arg._args;
       }
       throw new Error(
         `${argLabel(funcName, paramName, argPos)} must have type ${typeLabel(paramTypes)}`
@@ -404,26 +401,6 @@ function castArg(arg, funcName, paramName, argPos, paramTypes) {
             });
           }
           return true;
-        case 'PlanTransitiveClosureOptions':
-          const planTransitiveClosureOptionsSet = new Set(['minLength', 'min-length', 'maxLength', 'max-length']);
-          if(Object.getPrototypeOf(arg) === Map.prototype){
-            arg.forEach((value, key) => {
-              if(!planTransitiveClosureOptionsSet.has(key)) {
-                throw new Error(
-                    `${argLabel(funcName, paramName, argPos)} has invalid key- ${key}`
-                );
-              }
-            });
-          } else if (typeof arg === 'object') {
-            Object.keys(arg).forEach(key => {
-              if(!planTransitiveClosureOptionsSet.has(key)) {
-                throw new Error(
-                    `${argLabel(funcName, paramName, argPos)} has invalid key- ${key}`
-                );
-              }
-            });
-          }
-          return true;
       default:
         return false;
       }