-
Notifications
You must be signed in to change notification settings - Fork 3
fix(ci): ship src/data/*.json in published tarball #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+53
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,7 @@ jobs: | |
| name: package | ||
| path: | | ||
| dist/ | ||
| src/data/ | ||
| package.json | ||
| README.md | ||
| LICENSE | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { execSync } from "node:child_process"; | ||
| import { readFileSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| const repoRoot = join(__dirname, "../.."); | ||
|
|
||
| interface PackedFile { | ||
| path: string; | ||
| } | ||
|
|
||
| /** | ||
| * Collect every string file path referenced anywhere in the package.json | ||
| * `exports` map (recursing through conditional-export objects like | ||
| * `{ import: { types, default } }`). | ||
| */ | ||
| function collectExportTargets(exportsField: unknown, out: string[] = []): string[] { | ||
| if (typeof exportsField === "string") { | ||
| out.push(exportsField); | ||
| } else if (exportsField && typeof exportsField === "object") { | ||
| for (const value of Object.values(exportsField as Record<string, unknown>)) { | ||
| collectExportTargets(value, out); | ||
| } | ||
| } | ||
| return out; | ||
| } | ||
|
|
||
| describe("published package", () => { | ||
| // Run the real `npm pack` so we assert against the actual tarball contents, | ||
| // not the source tree. Regression guard for the `./data/*` exports that | ||
| // shipped dead in 0.2.5–0.2.7 because `src/data/` was missing at publish time. | ||
| const packed: PackedFile[] = JSON.parse( | ||
| execSync("npm pack --dry-run --json", { cwd: repoRoot, encoding: "utf8" }), | ||
| )[0].files; | ||
| const packedPaths = new Set(packed.map((f) => f.path)); | ||
|
|
||
| const pkg = JSON.parse(readFileSync(join(repoRoot, "package.json"), "utf8")); | ||
|
|
||
| // Only assert source-committed targets (e.g. src/data/*.json). `dist/*` | ||
| // targets are intentionally skipped: in CI `pnpm test` runs before | ||
| // `pnpm build`, so dist does not exist yet when this test executes. | ||
| const sourceTargets = collectExportTargets(pkg.exports) | ||
| .map((p) => p.replace(/^\.\//, "")) | ||
| .filter((p) => p.startsWith("src/")); | ||
|
|
||
| it("includes every src/ export target in the tarball", () => { | ||
| expect(sourceTargets.length).toBeGreaterThan(0); | ||
| for (const target of sourceTargets) { | ||
| expect(packedPaths, `${target} is referenced by exports but missing from the npm tarball`).toContain(target); | ||
| } | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.