fix: avoid underscore in fb function names

Author: ofr1tz

firebase/firebase.json

@@ -22,12 +22,12 @@
         "function": "osmAuth-token"
       },
       {
-        "source": "/redirect_web",
-        "function": "osmAuth-redirect_web"
+        "source": "/redirectweb",
+        "function": "osmAuth-redirectweb"
       },
       {
-        "source": "/token_web",
-        "function": "osmAuth-token_web"
+        "source": "/tokenweb",
+        "function": "osmAuth-tokenweb"
       }
     ]
   },

firebase/functions/src/index.ts

@@ -8,7 +8,7 @@ admin.initializeApp();
 // all functions are bundled together. It's less than ideal, but it does not
 // seem possible to split them using the split system for multiple sites from
 // https://firebase.google.com/docs/hosting/multisites
-import {redirect, token, redirect_web, token_web} from './osm_auth';
+import {redirect, token, redirectweb, tokenweb} from './osm_auth';
 import { formatProjectTopic, formatUserName } from './utils';
 
 exports.osmAuth = {};
@@ -23,12 +23,12 @@ exports.osmAuth.token = functions.https.onRequest((req, res) => {
     token(req, res, admin);
 });
 
-exports.osmAuth.redirect_web = functions.https.onRequest((req, res) => {
-    redirect_web(req, res);
+exports.osmAuth.redirectweb = functions.https.onRequest((req, res) => {
+    redirectweb(req, res);
 });
 
-exports.osmAuth.token_web = functions.https.onRequest((req, res) => {
-    token_web(req, res, admin);
+exports.osmAuth.tokenweb = functions.https.onRequest((req, res) => {
+    tokenweb(req, res, admin);
 });
 
 /*

firebase/functions/src/osm_auth.ts

@@ -101,7 +101,7 @@ export const redirect = (req: any, res: any) => {
     });
 };
 
-export const redirect_web = (req: any, res: any) => {
+export const redirectweb = (req: any, res: any) => {
     const oauth2 = osmOAuth2ClientWeb();
 
     cookieParser()(req, res, () => {
@@ -233,7 +233,7 @@ export const token = async (req: any, res: any, admin: any) => {
 };
 
 
-export const token_web = async (req: any, res: any, admin: any) => {
+export const tokenweb = async (req: any, res: any, admin: any) => {
     const oauth2 = osmOAuth2ClientWeb();
 
     try {
@@ -244,7 +244,7 @@ export const token_web = async (req: any, res: any, admin: any) => {
             );
             functions.logger.log('Received state:', req.query.state);
             // FIXME: For security, we need to check the cookie that was set
-            // in the /redirect_web function on the user's browser.
+            // in the /redirectweb function on the user's browser.
             // However, there seems to be a bug in firebase around this.
             // https://github.com/firebase/firebase-functions/issues/544
             // and linked SO question