Fix CQS signal facebook-hte-MissingExplicit in fbcode/mapillary/opensfm

Differential Revision: D90566661

fbshipit-source-id: 03072b0ec562539e50dab36971c566d33c88ffc4

Author: generatedunixname89002005287564

opensfm/src/geometry/pose.h

@@ -16,10 +16,10 @@ class Pose {
   }
   virtual ~Pose() = default;
 
-  Pose(const Vec3d& R, const Vec3d& t = Vec3d::Zero()) {
+  explicit Pose(const Vec3d& R, const Vec3d& t = Vec3d::Zero()) {
     SetFromWorldToCamera(R, t);
   }
-  Pose(const Mat3d& R, const Vec3d& t = Vec3d::Zero()) {
+  explicit Pose(const Mat3d& R, const Vec3d& t = Vec3d::Zero()) {
     Mat4d T_cw = Mat4d::Identity();
     T_cw.block<3, 3>(0, 0) = R;
     T_cw.block<3, 1>(0, 3) = t;

opensfm/src/map/dataviews.h

@@ -12,7 +12,7 @@ namespace map {
 class Map;
 class ShotView {
  public:
-  ShotView(Map& map);
+  explicit ShotView(Map& map);
   Shot& GetShot(const map::ShotId& shot_id);
   bool HasShot(const map::ShotId& shot_id) const;
   const std::unordered_map<ShotId, Shot>& GetShots() const;
@@ -24,7 +24,7 @@ class ShotView {
 
 class PanoShotView {
  public:
-  PanoShotView(Map& map);
+  explicit PanoShotView(Map& map);
   Shot& GetShot(const map::ShotId& shot_id);
   bool HasShot(const map::ShotId& shot_id) const;
   const std::unordered_map<ShotId, Shot>& GetShots() const;
@@ -36,7 +36,7 @@ class PanoShotView {
 
 class LandmarkView {
  public:
-  LandmarkView(Map& map);
+  explicit LandmarkView(Map& map);
   Landmark& GetLandmark(const LandmarkId& lm_id);
   bool HasLandmark(const LandmarkId& lm_id) const;
   const std::unordered_map<LandmarkId, Landmark>& GetLandmarks() const;
@@ -48,7 +48,7 @@ class LandmarkView {
 
 class CameraView {
  public:
-  CameraView(Map& map);
+  explicit CameraView(Map& map);
   size_t NumberOfCameras() const;
   geometry::Camera& GetCamera(const CameraId& cam_id);
   const std::unordered_map<CameraId, geometry::Camera>& GetCameras() const;

opensfm/src/robust/scorer.h

@@ -20,7 +20,7 @@ struct ScoreInfo {
 
 class RansacScoring {
  public:
-  RansacScoring(double threshold) : threshold_(threshold) {}
+  explicit RansacScoring(double threshold) : threshold_(threshold) {}
 
   template <class IT, class T>
   ScoreInfo<T> Score(IT begin, IT end,
@@ -40,7 +40,7 @@ class RansacScoring {
 class MedianBasedScoring {
  public:
   MedianBasedScoring() = default;
-  MedianBasedScoring(double nth) : nth_(nth) {}
+  explicit MedianBasedScoring(double nth) : nth_(nth) {}
 
   template <class IT>
   double ComputeMedian(IT begin, IT end) const {
@@ -60,7 +60,7 @@ class MedianBasedScoring {
 
 class MSacScoring {
  public:
-  MSacScoring(double threshold) : threshold_(threshold) {}
+  explicit MSacScoring(double threshold) : threshold_(threshold) {}
 
   template <class IT, class T>
   ScoreInfo<T> Score(IT begin, IT end,
@@ -85,7 +85,7 @@ class MSacScoring {
 
 class LMedSScoring : public MedianBasedScoring {
  public:
-  LMedSScoring(double multiplier)
+  explicit LMedSScoring(double multiplier)
       : MedianBasedScoring(0.5), multiplier_(multiplier) {}
 
   template <class IT, class T>