NAVAND-777: meet Vadzim's code review

Author: dzinad

instrumentation-tests/src/androidTest/java/com/mapbox/navigation/instrumentation_tests/core/RouteRefreshOnDemandTest.kt

@@ -159,77 +159,6 @@ class RouteRefreshOnDemandTest : BaseTest<EmptyTestActivity>(EmptyTestActivity::
             .toList()
     }
 
-    @Test
-    fun failed_route_refresh_on_demand_does_not_notify_refresh_observer_before_timeout() = sdkTest {
-        val refreshes = mutableListOf<RoutesUpdatedResult>()
-        val routeRefreshOptions = RouteRefreshOptions.Builder()
-            .intervalMillis(TimeUnit.MINUTES.toMillis(1))
-            .build()
-        failedRefreshHandlerWrapper.failResponse = true
-        createMapboxNavigation(routeRefreshOptions)
-        val routeOptions = generateRouteOptions(twoCoordinates)
-        val requestedRoutes = mapboxNavigation.requestRoutes(routeOptions)
-            .getSuccessfulResultOrThrowException()
-            .routes
-        mapboxNavigation.startTripSession()
-        mapboxNavigation.registerRoutesObserver {
-            if (it.reason == RoutesExtra.ROUTES_UPDATE_REASON_REFRESH) {
-                refreshes.add(it)
-            }
-        }
-        stayOnInitialPosition()
-        mapboxNavigation.setNavigationRoutesAndWaitForUpdate(requestedRoutes)
-
-        mapboxNavigation.routeRefreshController.requestImmediateRouteRefresh()
-        delay(2000)
-        assertEquals(0, refreshes.size)
-    }
-
-    @Test
-    fun failed_route_refresh_on_demand_notifies_refresh_observer_after_timeout() = sdkTest {
-        val routeRefreshOptions = createRouteRefreshOptionsWithInvalidInterval(3000)
-        failedRefreshHandlerWrapper.failResponse = true
-        createMapboxNavigation(routeRefreshOptions)
-        val routeOptions = generateRouteOptions(twoCoordinates)
-        val requestedRoutes = mapboxNavigation.requestRoutes(routeOptions)
-            .getSuccessfulResultOrThrowException()
-            .routes
-        mapboxNavigation.startTripSession()
-        stayOnInitialPosition()
-        mapboxNavigation.setNavigationRoutesAndWaitForUpdate(requestedRoutes)
-
-        delay(7000) // 2 failed planned attempts + accuracy
-        // fail and postpone next planned attempt
-        mapboxNavigation.routeRefreshController.requestImmediateRouteRefresh()
-        delay(2000)
-        // dispatch new routes with REFRESH reason
-        mapboxNavigation.routeRefreshController.requestImmediateRouteRefresh()
-
-        mapboxNavigation.routesUpdates()
-            .filter { it.reason == RoutesExtra.ROUTES_UPDATE_REASON_REFRESH }
-            .first()
-    }
-
-    @Test
-    fun route_refresh_on_demand_during_planned_request() = sdkTest {
-        val routeRefreshOptions = createRouteRefreshOptionsWithInvalidInterval(5000)
-        refreshHandler.jsonResponseModifier = DelayedResponseModifier(3000)
-        createMapboxNavigation(routeRefreshOptions)
-        val routeOptions = generateRouteOptions(twoCoordinates)
-        val requestedRoutes = mapboxNavigation.requestRoutes(routeOptions)
-            .getSuccessfulResultOrThrowException()
-            .routes
-        mapboxNavigation.startTripSession()
-        stayOnInitialPosition()
-        mapboxNavigation.setNavigationRoutesAndWaitForUpdate(requestedRoutes)
-
-        delay(6000) // refresh interval + accuracy
-        mapboxNavigation.routeRefreshController.requestImmediateRouteRefresh()
-        mapboxNavigation.routesUpdates()
-            .filter { it.reason == RoutesExtra.ROUTES_UPDATE_REASON_REFRESH }
-            .first()
-    }
-
     private fun createMapboxNavigation(routeRefreshOptions: RouteRefreshOptions) {
         mapboxNavigation = MapboxNavigationProvider.create(
             NavigationOptions.Builder(activity)