cache highlights

Author: maede97

include/entropy/hex_display_feature.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <cstdint>
+#include <map>
 #include <string>
 #include <vector>
 
@@ -28,6 +29,7 @@ class HexDisplayFeature {
         ImGui::PushID(getName().c_str());
         if (ImGui::ColorEdit4("Color", (float *)&col)) {
             color = ImGui::ColorConvertFloat4ToU32(col);
+            highlightCache.clear();
         }
         ImGui::PopID();
     }
@@ -36,6 +38,7 @@ class HexDisplayFeature {
             unsigned int color_value = 0;
             if (sscanf(value.c_str(), "0x%X", &color_value) == 1) {
                 color = color_value;
+                highlightCache.clear();
             }
         }
     }
@@ -53,6 +56,7 @@ class HexDisplayFeature {
 
   public:
     mutable uint32_t color = IM_COL32(255, 0, 0, 255); // Default red color
+    mutable std::map<size_t, std::vector<Highlight>> highlightCache;
 };
 
 } // namespace entropy

include/entropy/hexdisplay/aewf_detector.h

@@ -6,8 +6,6 @@
 
 #include <entropy/hex_display_feature.h>
 
-#include <iostream>
-
 namespace entropy {
 
 class AEWFDetector : public HexDisplayFeature {

include/entropy/hexdisplay/zero_bytes.h

@@ -37,7 +37,10 @@ class ZeroBytesFeature : public HexDisplayFeature {
         // Default Config (color)
         HexDisplayFeature::renderSettingsPanel();
 
-        ImGui::Checkbox("Color FF as well", &colorFF);
+        bool changed = ImGui::Checkbox("Color FF as well", &colorFF);
+        if (changed) {
+            highlightCache.clear();
+        }
 
         ImGui::PopID();
     }
@@ -59,6 +62,7 @@ class ZeroBytesFeature : public HexDisplayFeature {
     void setConfig(const std::string &key, const std::string &value) override {
         if (key == "colorFF") {
             colorFF = (value == "1");
+            highlightCache.clear();
             return;
         }
         // default options

src/ui.cpp

@@ -58,12 +58,29 @@ void renderHexViewWindow(UiState &uiState, const AppState &appState) {
             if (uiState.currentSectorData.empty()) {
                 ImGui::Text("No data available");
             } else {
+                // Clear highlight cache if sector changed
+                static size_t lastSectorIndex = SIZE_MAX;
+                if (lastSectorIndex != uiState.currentSectorIndex) {
+                    if (appState.hexDisplayFeatureManager) {
+                        for (auto *feature : appState.hexDisplayFeatureManager->getFeatures()) {
+                            feature->highlightCache.clear();
+                        }
+                    }
+                    lastSectorIndex = uiState.currentSectorIndex;
+                }
+
                 // Collect highlights from plugins
                 std::map<size_t, std::pair<uint32_t, int>> highlightMap; // color, priority
                 if (appState.hexDisplayFeatureManager) {
                     for (const auto *feature : appState.hexDisplayFeatureManager->getFeatures()) {
                         if (appState.featureEnabled.count(feature->getName()) && appState.featureEnabled.at(feature->getName())) {
-                            auto highlights = feature->getHighlights(uiState.currentSectorData, uiState.currentSectorIndex);
+                            std::vector<Highlight> highlights;
+                            if (feature->highlightCache.count(uiState.currentSectorIndex)) {
+                                highlights = feature->highlightCache[uiState.currentSectorIndex];
+                            } else {
+                                highlights = feature->getHighlights(uiState.currentSectorData, uiState.currentSectorIndex);
+                                feature->highlightCache[uiState.currentSectorIndex] = highlights;
+                            }
                             int priority = feature->getPriority();
                             for (const auto &h : highlights) {
                                 auto it = highlightMap.find(h.offset);