refactor: Use a consistent ascending config sort and cache decoded configs

The menu rendered configurations ascending by name, but did so with a
descending comparator combined with insert-at-zero, which read as the
opposite of the configurations window's ascending sort descriptor. Sort
ascending and insert the items as an ordered block so the comparator
matches the window while the rendered order is unchanged.

Cache the decoded configurations array in Preferences and invalidate it
on the defaultsChanged distributed notification, instead of decoding the
full plist on every access.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: macmade

Shared/Preferences.swift

@@ -46,6 +46,10 @@ public class Preferences: NSObject
                 return
             }
 
+            // A change elsewhere (or in another process) invalidates the cache
+            // so the next read re-decodes the stored plist.
+            self.cachedConfigurations = nil
+
             self.willChangeValue( for: \.configurations )
             self.didChangeValue(  for: \.configurations )
 
@@ -54,23 +58,39 @@ public class Preferences: NSObject
         }
     }
 
+    private var cachedConfigurations: [ Configuration ]?
+
     @objc public dynamic var configurations: [ Configuration ]
     {
         get
         {
+            if let cached = self.cachedConfigurations
+            {
+                return cached
+            }
+
+            let decoded: [ Configuration ]
+
             if let data    = self.defaults?.object( forKey: "configurations" ) as? Data,
-               let decoded = try? PropertyListDecoder().decode( [ Configuration ].self, from: data )
+               let stored  = try? PropertyListDecoder().decode( [ Configuration ].self, from: data )
             {
-                return decoded
+                decoded = stored
             }
+            else
+            {
+                decoded = []
+            }
+
+            self.cachedConfigurations = decoded
 
-            return []
+            return decoded
         }
 
         set( value )
         {
             if let data = try? PropertyListEncoder().encode( value )
             {
+                self.cachedConfigurations = value
                 self.defaults?.setValue( data, forKey: "configurations" )
                 DistributedNotificationCenter.default().post( name: Preferences.defaultsChanged, object: nil )
             }

XcodeFormat/Classes/ApplicationDelegate.swift

@@ -175,11 +175,14 @@ public class ApplicationDelegate: NSObject, NSApplicationDelegate
         let imageOn  = image?.withSymbolConfiguration( NSImage.SymbolConfiguration( hierarchicalColor: colorOn ) )
         let imageOff = image?.withSymbolConfiguration( NSImage.SymbolConfiguration( hierarchicalColor: colorOff ) )
 
-        Preferences.shared.configurations.sorted
+        // Ascending by name, matching the configurations window's sort. The
+        // items are inserted as a block at the top so the rendered order is the
+        // ascending sort order.
+        let configurationItems: [ NSMenuItem ] = Preferences.shared.configurations.sorted
         {
-            $0.name > $1.name
+            $0.name < $1.name
         }
-        .forEach
+        .map
         {
             let item               = NSMenuItem( title: $0.name, action: #selector( self.selectConfiguration( _: ) ), keyEquivalent: "" )
             item.target            = self
@@ -198,9 +201,11 @@ public class ApplicationDelegate: NSObject, NSApplicationDelegate
                 item.attributedTitle = NSAttributedString( string: item.title, attributes: [ .font: fontOff, .foregroundColor: colorOff ] )
             }
 
-            items.insert( item, at: 0 )
+            return item
         }
 
+        items.insert( contentsOf: configurationItems, at: 0 )
+
         self.menu.items = items
     }