- set file operations to single thread by default

- add multithreading to MediaInfoProvider, related changes
- don't disable labels for UI during generation

Author: SanderSade

QuickList/Application/Configuration.cs

@@ -81,8 +81,8 @@ internal static Configuration Parse(string iniFile)
 				ForceShellMedia = IniReader.ReadValue("QuickList", "ForceShellMedia", iniFile, "0") == "1"
 			};
 
-			int.TryParse(IniReader.ReadValue("QuickList", "FileReaderParallelism", "0"), out var fileReaderParallelism);
-			configuration.FileReaderParallelism = fileReaderParallelism <= 0 ? Environment.ProcessorCount : fileReaderParallelism;
+			int.TryParse(IniReader.ReadValue("QuickList", "FileReaderParallelism", "1"), out var fileReaderParallelism);
+			configuration.FileReaderParallelism = fileReaderParallelism;
 
 			var dirsFile = IniReader.ReadValue("ListMagic", "DirsFile", iniFile);
 

QuickList/Application/MediaCache.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
@@ -10,7 +11,7 @@ namespace Sander.QuickList.Application
 	internal sealed class MediaCache
 	{
 		private readonly Configuration _configuration;
-		private readonly List<Entry> _newCache = new List<Entry>();
+		private readonly ConcurrentBag<Entry> _newCache = new ConcurrentBag<Entry>();
 		private Dictionary<string, Entry> _mediaCache;
 
 

QuickList/Application/MediaInfoProvider.cs

@@ -60,7 +60,12 @@ internal Task AddMediaInfo(List<Entry> entries)
 				timer.Elapsed += (sender, args) => _configuration.Status = Status.Get("Getting media info", percentage);
 			}
 
-			entries.ForEach(entry =>
+			entries
+				.AsParallel()
+				.WithDegreeOfParallelism(_configuration.FileReaderParallelism)
+				.WithExecutionMode(ParallelExecutionMode.ForceParallelism)
+				//.ForEach(entry =>
+				.ForAll(entry =>
 						 {
 
 							 percentage += step;
@@ -119,36 +124,40 @@ private bool GetTagLibInfo(Entry entry)
 			catch (Exception e)
 			{
 				Trace.WriteLine($"Problem getting media info for \"{entry.Fullname}\". Error:\r\n{e.Source}: {e.Message}");
-			return false;
+				return false;
 			}
 		}
 
 
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
-		private static void GetShellInfo(Entry entry)
+		private void GetShellInfo(Entry entry)
 		{
-			using (var shellFile = ShellFile.FromFilePath(entry.Fullname))
+			lock (this)
 			{
-				var durationNs = shellFile.Properties.System.Media.Duration.Value;
-				if (durationNs == null || durationNs == 0)
-					return;
-
-				var duration = TimeSpan.FromMilliseconds(durationNs.Value * 0.0001);
-				//cheap video detection
-				if (shellFile.Properties.System.Video.FrameWidth.Value.HasValue)
+				using (var shellFile = ShellFile.FromFilePath(entry.Fullname))
 				{
-					var video = shellFile.Properties.System.Video;
-					entry.MediaInfo = FormatVideo(duration,
-						(int)(video.FrameWidth.Value ?? 0),
-						(int)(video.FrameHeight.Value ?? 0),
-						video.FrameRate.Value / 1000);
-				}
-				else if (shellFile.Properties.System.Audio.ChannelCount.Value.HasValue)
-				{
-					entry.MediaInfo = FormatAudio(duration,
-						(int)((shellFile.Properties.System.Audio.EncodingBitrate.Value ?? 0) / 1000),
-						(shellFile.Properties.System.Audio.SampleRate.Value ?? 0) / 1000f,
-						(int)shellFile.Properties.System.Audio.ChannelCount.Value.Value);
+					var durationNs = shellFile.Properties.System.Media.Duration.Value;
+					if (durationNs == null || durationNs == 0)
+						return;
+
+					var duration = TimeSpan.FromMilliseconds(durationNs.Value * 0.0001);
+					//cheap video detection
+					if (shellFile.Properties.System.Video.FrameWidth.Value.HasValue)
+					{
+						var video = shellFile.Properties.System.Video;
+						entry.MediaInfo = FormatVideo(duration,
+							(int)(video.FrameWidth.Value ?? 0),
+							(int)(video.FrameHeight.Value ?? 0),
+							video.FrameRate.Value / 1000);
+					}
+					else if (shellFile.Properties.System.Audio.ChannelCount.Value.HasValue)
+					{
+						entry.MediaInfo = FormatAudio(duration,
+							(int)((shellFile.Properties.System.Audio.EncodingBitrate.Value ?? 0) / 1000),
+							(shellFile.Properties.System.Audio.SampleRate.Value ?? 0) / 1000f,
+							(int)shellFile.Properties.System.Audio.ChannelCount.Value.Value);
+
+					}
 				}
 			}
 		}

QuickList/UI/MainForm.cs

@@ -2,7 +2,6 @@
 using System.Diagnostics;
 using System.IO;
 using System.Reflection;
-using System.Threading;
 using System.Threading.Tasks;
 using System.Windows.Forms;
 using Sander.QuickList.Application;
@@ -73,7 +72,11 @@ private void CurrentListLabel_Click(object sender, EventArgs e)
 
 		private void Disable(Control control)
 		{
-			control.Enabled = false;
+			if (control is Label || control.Name == "CurrentListPanel")
+				return;
+
+			if (control != this)
+				control.Enabled = false;
 			foreach (Control child in control.Controls)
 			{
 				Disable(child);