Skip to content

Commit c5925bd

Browse files
authored
Update schema default value and readme (conda#1088)
* Clarify text in readme header * Update default enable_currentUserHome to reflect the documentation * Add news * Apply review suggestions
1 parent 15f2521 commit c5925bd

4 files changed

Lines changed: 22 additions & 3 deletions

File tree

constructor/_schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ class ConstructorConfiguration(BaseModel):
610610
Internally, this is passed to `pkgbuild --install-location`.
611611
macOS only.
612612
"""
613-
pkg_domains: dict[PkgDomains, bool] = {"enable_anywhere": True, "enable_currentUserHome": False}
613+
pkg_domains: dict[PkgDomains, bool] = {"enable_anywhere": True, "enable_currentUserHome": True}
614614
"""
615615
The domains the package can be installed into. For a detailed explanation, see:
616616
https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html

constructor/data/construct.schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,7 @@
921921
},
922922
"default": {
923923
"enable_anywhere": true,
924-
"enable_currentUserHome": false
924+
"enable_currentUserHome": true
925925
},
926926
"description": "The domains the package can be installed into. For a detailed explanation, see: https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html constructor defaults to `enable_anywhere=true` and `enable_currentUserHome=true`. `enable_localSystem` should not be set to true unless `default_location_pkg` is set as well. macOS only.",
927927
"propertyNames": {

constructor/osx/readme_header.rtf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
\f0\fs30 \cf0 Anaconda is the most popular Python data science platform. See {\field{\*\fldinst{HYPERLINK "https://www.anaconda.com/downloads"}}{\fldrslt https://www.anaconda.com/downloads}}/.\
1212
\
13-
By default, this installer modifies your bash profile to activate the base environment of __NAME__ when your shell starts up. To disable this, choose "Customize" at the "Installation Type" phase, and disable the "Modify PATH" option. If you decline this option, the executables installed by this installer will not be available on PATH. You will need to use the full executable path to run commands, or otherwise initialize the base environment of __NAME__ on your own. \
13+
By default, this installer modifies all available shells to activate the base environment of __NAME__ when the shell starts up. To disable this, choose "Customize" at the "Installation Type" phase, and disable the "Modify PATH" option. If you decline this option, the executables installed by this installer will not be available on PATH. You will need to use the full executable path to run commands, or otherwise initialize the base environment of __NAME__ on your own. \
1414
\
1515
To install to a different location, select "Change Install Location..." at the "Installation Type" phase, then choose "Install on a specific disk...", choose the disk you wish to install on, and click "Choose Folder...". The "Install for me only" option will install __NAME__ to the default location, ~/__NAME_LOWER__.\
1616
\
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
### Enhancements
2+
3+
* <news item>
4+
5+
### Bug fixes
6+
7+
* PKG: Restore the default value of `enable_currentUserHome` to the old default value (`true`). (#1070 via #1088)
8+
9+
### Deprecations
10+
11+
* <news item>
12+
13+
### Docs
14+
15+
* PKG: Clarify that the profile of all available shells will be modified by default. (#1070 via #1088)
16+
17+
### Other
18+
19+
* <news item>

0 commit comments

Comments
 (0)