Automatically detach ftdi_sio driver

In linux the kernel will automatically bind the ftdi device to the
ftdi_sio driver, this prevents the lib D2XX to discover the ftdi.

Signed-off-by: Douglas Reis <doreis@lowrisc.org>

Author: engdoreis

app/main.cc

@@ -21,8 +21,8 @@
 
 using Action = std::function<int()>;
 
-static std::vector<ftdi::DeviceInfo> scan() {
-  auto result = ftdi::Discovery::scan();
+static std::vector<ftdi::DeviceInfo> scan(uint16_t pid = 0x6010) {
+  auto result = ftdi::Discovery::scan(pid);
   if (!result) {
     std::cerr << "Error: Failed to communicate with FTDI driver." << std::endl;
     exit(0);
@@ -61,11 +61,11 @@ new_flash_command(const std::string& name, const std::string& desc) {
 }
 
 static std::optional<ftdi::SpiHost>
-handle_flash_command(std::unique_ptr<argparse::ArgumentParser>& cmd) {
+handle_flash_command(std::unique_ptr<argparse::ArgumentParser>& cmd, uint16_t pid) {
   auto ftdi     = cmd->get<std::string>("--ftdi");
   auto traces   = cmd->get<bool>("--traces");
   auto clock    = cmd->get<size_t>("--clock");
-  auto devices  = scan();
+  auto devices  = scan(pid);
   auto filtered = ftdi::DeviceInfo::filter_by_description(devices, ftdi);
   if (filtered.empty()) {
     std::print("No {} ftdi found.\n", ftdi);
@@ -81,9 +81,9 @@ handle_flash_command(std::unique_ptr<argparse::ArgumentParser>& cmd) {
 }
 
 static std::optional<ftdi::Gpio>
-handle_gpio_command(std::unique_ptr<argparse::ArgumentParser>& cmd) {
+handle_gpio_command(std::unique_ptr<argparse::ArgumentParser>& cmd, uint16_t pid) {
   auto ftdi_filter = cmd->get<std::string>("--ftdi");
-  auto devices     = scan();
+  auto devices     = scan(pid);
   auto filtered    = ftdi::DeviceInfo::filter_by_description(devices, ftdi_filter);
   if (filtered.empty()) {
     std::print("No {} ftdi found.\n", ftdi_filter);
@@ -100,13 +100,20 @@ int main(int argc, char* argv[]) {
   std::map<std::string, Action> commands;
 
   argparse::ArgumentParser program("ftditool");
+  program.add_argument("--pid")
+      .default_value(std::uint16_t{0x6010})
+      .help(
+          "The usb product id, in case the ftdi_sio driver needs to be detached. Defaults to "
+          "FT2232H")
+      .scan<'x', std::uint16_t>();
 
   argparse::ArgumentParser list_devices_cmd("list-devices");
   list_devices_cmd.add_description("List FTDI devices.");
   program.add_subparser(list_devices_cmd);
   commands["list-devices"] = [&]() -> int {
+    auto pid = program.get<uint16_t>("--pid");
     auto idx = 0;
-    for (auto device : scan()) {
+    for (auto device : scan(pid)) {
       std::print("{}: {}\n", idx++, device);
     }
     return 0;
@@ -115,7 +122,8 @@ int main(int argc, char* argv[]) {
   auto jedec_cmd = new_flash_command("jedec", "Read the JEDEC identifier.");
   program.add_subparser(*jedec_cmd);
   commands["jedec"] = [&]() -> int {
-    auto spih = handle_flash_command(jedec_cmd);
+    auto pid  = program.get<uint16_t>("--pid");
+    auto spih = handle_flash_command(jedec_cmd, pid);
     commands::ReadJedec(flash::Generic(*spih)).run();
     spih->close();
     return 0;
@@ -124,7 +132,8 @@ int main(int argc, char* argv[]) {
   auto sfdp_cmd = new_flash_command("sfdp", "Read serial flash description.");
   program.add_subparser(*sfdp_cmd);
   commands["sfdp"] = [&]() -> int {
-    auto spih = handle_flash_command(sfdp_cmd);
+    auto pid  = program.get<uint16_t>("--pid");
+    auto spih = handle_flash_command(sfdp_cmd, pid);
     commands::ReadSfdp(flash::Generic(*spih)).run();
     spih->close();
     return 0;
@@ -134,8 +143,9 @@ int main(int argc, char* argv[]) {
   read_page_cmd->add_argument("--addr").help("The page address").scan<'x', std::size_t>();
   program.add_subparser(*read_page_cmd);
   commands["read-page"] = [&]() -> int {
+    auto pid  = program.get<uint16_t>("--pid");
     auto addr = read_page_cmd->get<std::size_t>("--addr");
-    auto spih = handle_flash_command(read_page_cmd);
+    auto spih = handle_flash_command(read_page_cmd, pid);
     commands::ReadPage(flash::Generic(*spih), addr).run();
     spih->close();
     return 0;
@@ -150,9 +160,10 @@ int main(int argc, char* argv[]) {
   test_page_cmd->add_argument("--quad").help("Use qSPI").default_value(false).implicit_value(true);
   program.add_subparser(*test_page_cmd);
   commands["test-page"] = [&]() -> int {
+    auto pid  = program.get<uint16_t>("--pid");
     auto addr = test_page_cmd->get<std::size_t>("--addr");
     auto quad = test_page_cmd->get<bool>("--quad");
-    auto spih = handle_flash_command(test_page_cmd);
+    auto spih = handle_flash_command(test_page_cmd, pid);
     commands::TestPage(flash::Generic(*spih), addr, quad).run();
 
     spih->close();
@@ -169,10 +180,11 @@ int main(int argc, char* argv[]) {
   load_file_cmd->add_argument("--quad").help("Use qSPI").default_value(false).implicit_value(true);
   program.add_subparser(*load_file_cmd);
   commands["load-file"] = [&]() -> int {
+    auto pid      = program.get<uint16_t>("--pid");
     auto filename = load_file_cmd->get<std::string>("filename");
     auto addr     = load_file_cmd->get<std::size_t>("--addr");
     auto quad     = load_file_cmd->get<bool>("--quad");
-    auto spih     = handle_flash_command(load_file_cmd);
+    auto spih     = handle_flash_command(load_file_cmd, pid);
     commands::LoadFile(flash::Generic(*spih), filename, addr, false, quad).run();
 
     spih->close();
@@ -192,10 +204,11 @@ int main(int argc, char* argv[]) {
       .implicit_value(true);
   program.add_subparser(*verify_file_cmd);
   commands["verify-file"] = [&]() -> int {
+    auto pid      = program.get<uint16_t>("--pid");
     auto filename = verify_file_cmd->get<std::string>("filename");
     auto addr     = verify_file_cmd->get<std::size_t>("--addr");
     auto quad     = verify_file_cmd->get<bool>("--quad");
-    auto spih     = handle_flash_command(verify_file_cmd);
+    auto spih     = handle_flash_command(verify_file_cmd, pid);
     commands::VerifyFile(flash::Generic(*spih), filename, addr, quad).run();
 
     spih->close();
@@ -212,10 +225,11 @@ int main(int argc, char* argv[]) {
   bootstrap_cmd->add_argument("--quad").help("Use qSPI").default_value(false).implicit_value(true);
   program.add_subparser(*bootstrap_cmd);
   commands["bootstrap"] = [&]() -> int {
+    auto pid      = program.get<uint16_t>("--pid");
     auto filename = bootstrap_cmd->get<std::string>("filename");
     auto addr     = bootstrap_cmd->get<std::size_t>("--addr");
     auto quad     = bootstrap_cmd->get<bool>("--quad");
-    auto spih     = handle_flash_command(bootstrap_cmd);
+    auto spih     = handle_flash_command(bootstrap_cmd, pid);
     commands::LoadFile(flash::Generic(*spih), filename, addr, true, quad).run();
 
     spih->close();
@@ -227,9 +241,10 @@ int main(int argc, char* argv[]) {
   gpio_write_cmd->add_argument("value").help("Value to write (0 or 1)").required().scan<'d', int>();
   program.add_subparser(*gpio_write_cmd);
   commands["gpio-write"] = [&]() -> int {
+    auto pid   = program.get<uint16_t>("--pid");
     auto pin   = static_cast<uint8_t>(gpio_write_cmd->get<int>("pin"));
     auto value = gpio_write_cmd->get<int>("value") != 0;
-    auto gpio  = handle_gpio_command(gpio_write_cmd);
+    auto gpio  = handle_gpio_command(gpio_write_cmd, pid);
     commands::GpioWrite(*gpio, pin, value).run();
     gpio->close();
     return 0;

flake.nix

@@ -42,7 +42,7 @@
             ft4222
             libmpsse
           ];
-          buildInputs = [ft4222 libmpsse ftd2xx];
+          buildInputs = with pkgs; [ft4222 libmpsse ftd2xx libusb1 systemd];
           shellHook = ''
             # Setting LD_LIBRARY_PATH for libftd2xx
             export LD_LIBRARY_PATH="${ftd2xx}/lib:$LD_LIBRARY_PATH"

lib/ftdi/CMakeLists.txt

@@ -8,6 +8,7 @@ target_sources(ftdipp
     PRIVATE
         spi_host.cc
         gpio.cc
+        libusb.cc
     PUBLIC
         FILE_SET HEADERS
         BASE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}
@@ -16,6 +17,7 @@ target_sources(ftdipp
             spi_host.hh
             gpio.hh
             log.hh
+            libusb.hh
 )
 
 target_include_directories(ftdipp
@@ -25,7 +27,8 @@ target_include_directories(ftdipp
 )
 
 target_link_libraries(ftdipp
-    PUBLIC magic_enum::magic_enum embeddedpp mpsse ft4222 
+    PUBLIC magic_enum::magic_enum embeddedpp mpsse ft4222
+    PRIVATE usb-1.0 udev
 )
 target_compile_options(ftdipp PRIVATE "-fno-exceptions")
 

lib/ftdi/ftdi.hh

@@ -5,11 +5,11 @@
 #pragma once
 
 #include "ftd2xx.h"
-#include <cstdint>
 #include <optional>
 #include <vector>
 #include <iostream>
 #include "device_info.hh"
+#include "libusb.hh"
 
 namespace ftdi {
 
@@ -19,7 +19,11 @@ class Discovery {
    * @brief Scans for all connected FTDI devices.
    * @return A vector of devices if successful, or std::nullopt if the driver call failed.
    */
-  static std::optional<std::vector<DeviceInfo>> scan() {
+
+  static std::optional<std::vector<DeviceInfo>> scan(uint16_t pid) {
+    // Detach ftdi_sio (if present) so D2XX can enumerate the device.
+    detach_ftdi_sio(pid);
+
     DWORD num_devs = 0;
 
     // 1. Get the number of devices

nix/ftditool.nix

@@ -12,6 +12,8 @@
   argparse,
   magic-enum,
   picosha2,
+  libusb1,
+  systemd,
   makeWrapper,
 }:
 stdenv.mkDerivation {
@@ -33,6 +35,8 @@ stdenv.mkDerivation {
     magic-enum
     picosha2
     ftd2xx
+    libusb1
+    systemd
   ];
 
   cmakeFlags = [