Mapping of umlauts broken

[qqilihq]

Hi all,

previous versions of Limax mapped German umlauts to the proper counterpart (e.g. ü will become ue). With the change in #44 and 4.0 unfortunately this breaks, and ü will now be mapped to a simple u which would be considered “less correct” in German.

Also, trying to fix it via a custom mapping will not help, as the _.deburr replacement happens without considering the given mappings. Our current workaround replaces them before applying limax:

  const fixedMapping = {
    ä: 'ae',
    Ä: 'Ae',
    ö: 'oe',
    Ö: 'Oe',
    ü: 'ue',
    Ü: 'Ue'
  };
  let fixedInput = input;
  for (const mapping of Object.entries(fixedMapping)) {
    fixedInput = fixedInput.replaceAll(mapping[0], mapping[1]);
  }

[lovell]

Thanks for reporting, as I mentioned in #49 (comment) it's probably a good time to vendor the upstream speakingurl and patch all the known bugs, which should allow us to drop the deburr dependency.

Happy to accept a PR to directly add the source code of https://github.com/pid/speakingurl/blob/master/lib/speakingurl.js (with the BSD-3-Clause licence added as a comment/header) instead of using it as a dependency.

[qqilihq]

Thank you for the feedback - I'll see if I find the time to come up with a MR during the next week 👍

[lovell]

Fixed in v4.2.3 via #54

[qqilihq]

Awesome - thank you @abhu85 @lovell