From 48df3c6a9ecbb4eabda40e68ec5c7743d8be4f9f Mon Sep 17 00:00:00 2001 From: Josh Hubbard Date: Thu, 23 Apr 2026 12:03:05 -0400 Subject: [PATCH] fix(docker): rename default container to localstack-aws --- README.md | 2 +- src/lib/docker/docker.client.test.ts | 10 +++++----- src/lib/docker/docker.client.ts | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 111c368..38bfa1c 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,7 @@ If you installed from source, change `command` and `args` to point to your local | Variable Name | Description | Default Value | | ------------- | ----------- | ------------- | | `LOCALSTACK_AUTH_TOKEN` (**required**) | The LocalStack Auth Token to use for the MCP server | None | -| `MAIN_CONTAINER_NAME` | The name of the LocalStack container to use for the MCP server | `localstack-main` | +| `MAIN_CONTAINER_NAME` | The name of the LocalStack container to use for the MCP server | `localstack-aws` | | `MCP_ANALYTICS_DISABLED` | Disable MCP analytics when set to `1` | `0` | ## Contributing diff --git a/src/lib/docker/docker.client.test.ts b/src/lib/docker/docker.client.test.ts index 8c135e9..579e3be 100644 --- a/src/lib/docker/docker.client.test.ts +++ b/src/lib/docker/docker.client.test.ts @@ -73,7 +73,7 @@ describe("DockerApiClient", () => { test("findLocalStackContainer returns id when found", async () => { const mocks = getDockerMocks(); - mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-main"] }]); + mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-aws"] }]); const client = new DockerApiClient(); await expect(client.findLocalStackContainer()).resolves.toBe("abc123"); @@ -84,7 +84,7 @@ describe("DockerApiClient", () => { const mocks = getDockerMocks(); mocks.listContainers.mockResolvedValueOnce([ - { Id: "not-this", Names: ["/localstack-main"] }, + { Id: "not-this", Names: ["/localstack-aws"] }, { Id: "xyz999", Names: ["/my-custom-localstack"] }, ]); @@ -98,13 +98,13 @@ describe("DockerApiClient", () => { const client = new DockerApiClient(); await expect(client.findLocalStackContainer()).rejects.toThrow( - /Could not find a running LocalStack container named "localstack-main"/i + /Could not find a running LocalStack container named "localstack-aws"/i ); }); test("executeInContainer returns stdout on success", async () => { const mocks = getDockerMocks(); - mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-main"] }]); + mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-aws"] }]); // prepare exec.inspect to return 0 mocks.execInspect.mockResolvedValueOnce({ ExitCode: 0 }); @@ -136,7 +136,7 @@ describe("DockerApiClient", () => { test("executeInContainer returns stderr on failure", async () => { const mocks = getDockerMocks(); - mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-main"] }]); + mocks.listContainers.mockResolvedValueOnce([{ Id: "abc123", Names: ["/localstack-aws"] }]); mocks.execInspect.mockResolvedValueOnce({ ExitCode: 2 }); const client = new DockerApiClient(); diff --git a/src/lib/docker/docker.client.ts b/src/lib/docker/docker.client.ts index 373bf12..5a54242 100644 --- a/src/lib/docker/docker.client.ts +++ b/src/lib/docker/docker.client.ts @@ -39,7 +39,7 @@ export class DockerApiClient { const configuredName = ( process.env.MAIN_CONTAINER_NAME || process.env.LOCALSTACK_MAIN_CONTAINER_NAME || - "localstack-main" + "localstack-aws" ).trim(); const byConfiguredName = (running || []).find((c) =>