[Bug]: file_to_map error parsing coinmasters.txt

[SalMonella01]

What's the bug?

TourGuide 2.2.2, on startup, using KoLmafia r28567, produces several error messages like these:

- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
-- is out of range, returning 0
- is out of range, returning 0
--- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0
- is out of range, returning 0

These error messages appear to be benign. They come from relay/relay_TourGuide.ash trying to parse coinmasters.txt in initialiseItemIngredients():

string [string,string,int,string] coinmasters_map;
file_to_map("data/coinmasters.txt", coinmasters_map);

The coinmasters_map structure appears to be incompatible with the coinmasters.txt file as currently distributed with KoLmafia.

Account State

Aftercore

In-Game Path & Class

Turtle Tamer in Unrestricted

TourGuide Commit

No response

[midgleyc]

Specifically, this occurs where:

• the row is formatted in the style where the second element is ROWXXXX
• the third element contains a dash

for example

Kiwi Kwiki Mart	ROW1489	mini kiwi-flavored aspirin-injecting lipstick	mini kiwi (3)
The Dedigitizer	ROW1565	familiar-in-the-middle wrapper	1 (64)	0 (16)	dedigitizer schematic: familiar-in-the-middle
Grandma Sea Monkey	ROW132	scale-mail underwear	dull fish scale (25)	pristine fish scale

[docrostov]

sorry this has been sitting for so long, i have been really busy and haven't really touched TG this year.

that makes sense re: the map being improperly reading. i'll do a few tests and see if i can figure out a better structure that's still backwards compatible without redoing all the old coinmaster tiles. thanks for bringing this to our attention!!

[docrostov]

fixed in #268