Skip to content

Commit 682aafc

Browse files
committed
CircleCI & Makefile: fixes needed for coreboot-git/cache reuse
CircleCI: depend on NV41 for save_cache Makefile: consider that coreboot-git is now shared between forks on x86 (Nitrokey/Purism share build/x86/coreboot-git now) Addressesses requested change at #1417 (review)
1 parent 9c8ced2 commit 682aafc

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,31 +215,31 @@ workflows:
215215
# version. The last board in the sequence is the dependency
216216
# for the parallel boards built at the end, and also save_cache.
217217

218-
# Coreboot 4.19
218+
# coreboot 4.19
219219
- build_and_persist:
220220
name: x230-hotp-maximized
221221
target: x230-hotp-maximized
222222
subcommand: ""
223223
requires:
224224
- prep_env
225225

226-
# Coreboot 4.17
226+
# coreboot-git librems
227227
- build_and_persist:
228228
name: librem_14
229229
target: librem_14
230230
subcommand: ""
231231
requires:
232232
- x230-hotp-maximized
233233

234-
# Coreboot Nitropads
234+
# coreboot-git Nitropads on top of coreboot-git librems
235235
- build_and_persist:
236236
name: nitropad-nv41
237237
target: nitropad-nv41
238238
subcommand: ""
239239
requires:
240240
- librem_14
241241

242-
# Coreboot for Talos (PPC)
242+
# coreboot-git Talos II (PPC)
243243
- build_and_persist:
244244
name: talos-2
245245
arch: ppc64
@@ -251,7 +251,6 @@ workflows:
251251
#Cache one workspace per architecture. Make sure workspace caches are chainloaded and the last in chain for an arch is saved.
252252
- save_cache:
253253
requires:
254-
- librem_14
255254
- talos-2
256255
- nitropad-nv41
257256

@@ -506,7 +505,7 @@ workflows:
506505
requires:
507506
- x230-hotp-maximized
508507

509-
#Coreboot 4.17 boards
508+
#coreboot-git librem boards
510509
- build:
511510
name: librem_13v2
512511
target: librem_13v2
@@ -549,6 +548,7 @@ workflows:
549548
requires:
550549
- librem_14
551550

551+
#coreboot-git Nitrokey NV
552552
- build:
553553
name: nitropad-ns50
554554
target: nitropad-ns50

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,9 @@ define define_module =
302302
echo -n '$($1_repo)|$($1_commit_hash)' > "$$@"; \
303303
elif [ "$$$$(cat "$$@")" != '$($1_repo)|$($1_commit_hash)' ]; then \
304304
echo "Switching $1 to $($1_repo) at $($1_commit_hash)" && \
305-
git -C "$(build)/$($1_base_dir)" fetch $($1_repo) $($1_commit_hash) && \
305+
git -C "$(build)/$($1_base_dir)" remote set-url origin $($1_repo) && \
306+
git -C "$(build)/$($1_base_dir)" reset --hard HEAD^ && \
307+
git -C "$(build)/$($1_base_dir)" checkout origin > /dev/null 2>&1 && \
306308
git -C "$(build)/$($1_base_dir)" reset --hard $($1_commit_hash) && \
307309
git -C "$(build)/$($1_base_dir)" clean -df && \
308310
git -C "$(build)/$($1_base_dir)" clean -dffx payloads util/cbmem && \

0 commit comments

Comments
 (0)