Skip to content

Commit 3163024

Browse files
authored
chore: remove unnecessary tests that duplicate language/framework guarantees (#108)
Remove ~100 tests across api, core, and app modules that provided no meaningful coverage: trivial default-value checks, data-class equals/copy (Kotlin guarantee), basic serialization round-trips (kotlinx.serialization guarantee), reimplemented formula tests not calling production code, and tests for test doubles. Retains all business-logic, validation, edge-case, backward-compatibility, and integration tests. Deleted files: DownloadScheduleTest, FileSelectionModeTest, SourceFileTest, InstanceManagerTest, DiscoveredServerTest.
1 parent a6f8139 commit 3163024

21 files changed

Lines changed: 0 additions & 1777 deletions

app/shared/src/commonTest/kotlin/com/linroid/ketch/app/FormatUtilsTest.kt

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package com.linroid.ketch.app
22

3-
import com.linroid.ketch.api.DownloadPriority
43
import com.linroid.ketch.app.util.extractFilename
54
import com.linroid.ketch.app.util.formatBytes
65
import com.linroid.ketch.app.util.formatEta
7-
import com.linroid.ketch.app.util.priorityLabel
86
import kotlin.test.Test
97
import kotlin.test.assertEquals
108

@@ -243,41 +241,4 @@ class FormatUtilsTest {
243241
extractFilename(" https://example.com/file.zip ")
244242
)
245243
}
246-
247-
// -----------------------------------------------------------
248-
// priorityLabel
249-
// -----------------------------------------------------------
250-
251-
@Test
252-
fun priorityLabel_low() {
253-
assertEquals("Low", priorityLabel(DownloadPriority.LOW))
254-
}
255-
256-
@Test
257-
fun priorityLabel_normal() {
258-
assertEquals("Normal", priorityLabel(DownloadPriority.NORMAL))
259-
}
260-
261-
@Test
262-
fun priorityLabel_high() {
263-
assertEquals("High", priorityLabel(DownloadPriority.HIGH))
264-
}
265-
266-
@Test
267-
fun priorityLabel_urgent() {
268-
assertEquals("Urgent", priorityLabel(DownloadPriority.URGENT))
269-
}
270-
271-
@Test
272-
fun priorityLabel_allEntriesCovered() {
273-
// Ensure every enum entry produces a non-blank label
274-
DownloadPriority.entries.forEach { priority ->
275-
val label = priorityLabel(priority)
276-
assertEquals(
277-
true,
278-
label.isNotBlank(),
279-
"Priority $priority should have a non-blank label"
280-
)
281-
}
282-
}
283244
}

app/shared/src/commonTest/kotlin/com/linroid/ketch/app/InstanceManagerTest.kt

Lines changed: 0 additions & 337 deletions
This file was deleted.

0 commit comments

Comments
 (0)