Added changeset

Author: grevanak-akamai

packages/manager/.changeset/pr-13410-changed-1772435694557.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Changed
+---
+
+Make firewall selection mandatory while creating linode and its interfaces ([#13410](https://github.com/linode/manager/pull/13410))

packages/manager/cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts

@@ -401,7 +401,7 @@ describe('Community Stackscripts integration tests', () => {
 
     // Select a firewall
     linodeCreatePage.selectFirewall(
-      mockFirewall.label,
+      'No firewall - traffic is unprotected (not recommended)',
       'Public Interface Firewall'
     );
 

packages/manager/src/features/Firewalls/components/FirewallSelect.tsx

@@ -67,6 +67,7 @@ export const FirewallSelect = <DisableClearable extends boolean>(
     hideDefaultChips,
     label,
     loading,
+    options,
     showNoFirewallOption = true,
     value,
     warningMessageForNoFirewallOption,
@@ -78,12 +79,12 @@ export const FirewallSelect = <DisableClearable extends boolean>(
   const { defaultNumEntities, isDefault, tooltipText } =
     useDefaultFirewallChipInformation(value, hideDefaultChips);
 
-  const options = useMemo(
+  const firewallOptions = useMemo(
     () => [
-      ...(firewalls ?? []),
+      ...(options ? options : (firewalls ?? [])),
       ...(showNoFirewallOption ? [noFirewallOption] : []),
     ],
-    [firewalls, showNoFirewallOption]
+    [firewalls, options, showNoFirewallOption]
   );
 
   const selectedFirewall = useMemo(
@@ -102,7 +103,7 @@ export const FirewallSelect = <DisableClearable extends boolean>(
         label={label ?? 'Firewall'}
         loading={isLoading || loading}
         noMarginTop
-        options={options}
+        options={firewallOptions}
         placeholder="Select a Firewall"
         renderOption={({ key, ...props }, option, state) => (
           <FirewallSelectOption

packages/manager/src/features/Linodes/LinodeCreate/resolvers.ts

@@ -38,10 +38,6 @@ export const getLinodeCreateResolver = (
       values.linodeInterfaces = values.linodeInterfaces.map(
         getCleanedLinodeInterfaceValues
       );
-      if (tab === 'Clone Linode' && !values.firewall_id) {
-        // The Clone Linode flow does not have the firewall_id field under interfaces object, so we set firewall_id to -1 to bypass the firewall requirement in the validation schema.
-        values.firewall_id = -1;
-      }
       if (
         values.interface_generation === 'legacy_config' ||
         tab === 'Clone Linode'

packages/validation/src/linodes.schema.ts

@@ -872,7 +872,7 @@ export const CreateLinodeSchema = object({
           }),
     }),
   metadata: MetadataSchema.notRequired().default(undefined),
-  firewall_id: number().nullable(),
+  firewall_id: number().nullable().notRequired(),
   placement_group: PlacementGroupPayloadSchema.notRequired().default(undefined),
   disk_encryption: DiskEncryptionSchema,
   maintenance_policy: string()