From 0adb33bb19b06733b2b2e2374a1b233bd2a9cbcb Mon Sep 17 00:00:00 2001 From: Ondrej Kunc Date: Wed, 13 May 2026 09:44:37 +0200 Subject: [PATCH] Bugfix VPC api call failures could cause deletion of all nodes --- cloud/linode/services/instances.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cloud/linode/services/instances.go b/cloud/linode/services/instances.go index 4faccc06..9d4de001 100644 --- a/cloud/linode/services/instances.go +++ b/cloud/linode/services/instances.go @@ -103,8 +103,7 @@ func (nc *nodeCache) refreshInstances(ctx context.Context, client client.Client) } resp, err := GetVPCIPAddresses(ctx, client, vpcName) if err != nil { - klog.Errorf("failed updating instances cache for VPC %s. Error: %s", vpcName, err.Error()) - continue + return fmt.Errorf("failed updating instances cache for VPC %s: %w", vpcName, err) } for _, vpcip := range resp { if vpcip.Address == nil { @@ -115,8 +114,7 @@ func (nc *nodeCache) refreshInstances(ctx context.Context, client client.Client) resp, err = GetVPCIPv6Addresses(ctx, client, vpcName) if err != nil { - klog.Errorf("failed updating instances cache for VPC %s. Error: %s", vpcName, err.Error()) - continue + return fmt.Errorf("failed updating instances cache for VPC %s: %w", vpcName, err) } for _, vpcip := range resp { if len(vpcip.IPv6Addresses) == 0 {