Skip to content

Commit e44e868

Browse files
crleonacrleona
authored
Enable and fix more warnings (#58)
* Enable and fix more warnings * Bump version and use int vs uint
1 parent 50e61d4 commit e44e868

31 files changed

Lines changed: 347 additions & 243 deletions

‎LayoutTest.podspec‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |spec|
22
spec.name = 'LayoutTest'
3-
spec.version = '5.0.2'
3+
spec.version = '5.0.3'
44
spec.license = { :type => 'Apache License, Version 2.0' }
55
spec.homepage = 'https://linkedin.github.io/LayoutTest-iOS'
66
spec.authors = 'LinkedIn'
@@ -16,18 +16,18 @@ Pod::Spec.new do |spec|
1616

1717
spec.subspec 'TestCase' do |sp|
1818
sp.source_files = 'LayoutTest/TestCase'
19-
sp.dependency 'LayoutTestBase/Autolayout', '5.0.2'
20-
sp.dependency 'LayoutTestBase/Catalog', '5.0.2'
21-
sp.dependency 'LayoutTestBase/Config', '5.0.2'
22-
sp.dependency 'LayoutTestBase/Core', '5.0.2'
23-
sp.dependency 'LayoutTestBase/UIViewHelpers', '5.0.2'
19+
sp.dependency 'LayoutTestBase/Autolayout', '5.0.3'
20+
sp.dependency 'LayoutTestBase/Catalog', '5.0.3'
21+
sp.dependency 'LayoutTestBase/Config', '5.0.3'
22+
sp.dependency 'LayoutTestBase/Core', '5.0.3'
23+
sp.dependency 'LayoutTestBase/UIViewHelpers', '5.0.3'
2424
sp.framework = 'XCTest'
2525
end
2626

2727
spec.subspec 'SwiftSubspec' do |sp|
2828
sp.source_files = 'LayoutTest/Swift', 'LayoutTest/LayoutTest.h'
2929
sp.dependency 'LayoutTest/TestCase'
30-
sp.dependency 'LayoutTestBase/Swift', '5.0.2'
30+
sp.dependency 'LayoutTestBase/Swift', '5.0.3'
3131
end
3232
end
3333

‎LayoutTest.xcodeproj/project.pbxproj‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,6 +841,7 @@
841841
CLANG_CXX_LIBRARY = "libc++";
842842
CLANG_ENABLE_MODULES = YES;
843843
CLANG_ENABLE_OBJC_ARC = YES;
844+
CLANG_UNDEFINED_BEHAVIOR_SANITIZER_NULLABILITY = YES;
844845
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
845846
CLANG_WARN_BOOL_CONVERSION = YES;
846847
CLANG_WARN_COMMA = YES;
@@ -849,14 +850,19 @@
849850
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
850851
CLANG_WARN_EMPTY_BODY = YES;
851852
CLANG_WARN_ENUM_CONVERSION = YES;
853+
CLANG_WARN_FLOAT_CONVERSION = YES;
854+
CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;
852855
CLANG_WARN_INFINITE_RECURSION = YES;
853856
CLANG_WARN_INT_CONVERSION = YES;
854857
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
858+
CLANG_WARN_NULLABLE_TO_NONNULL_CONVERSION = YES;
859+
CLANG_WARN_OBJC_EXPLICIT_OWNERSHIP_TYPE = YES;
855860
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
856861
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
857862
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
858863
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
859864
CLANG_WARN_STRICT_PROTOTYPES = YES;
865+
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
860866
CLANG_WARN_SUSPICIOUS_MOVE = YES;
861867
CLANG_WARN_UNREACHABLE_CODE = YES;
862868
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -874,9 +880,13 @@
874880
GCC_SYMBOLS_PRIVATE_EXTERN = NO;
875881
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
876882
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
883+
GCC_WARN_MISSING_PARENTHESES = YES;
884+
GCC_WARN_SHADOW = YES;
877885
GCC_WARN_UNDECLARED_SELECTOR = YES;
878886
GCC_WARN_UNINITIALIZED_AUTOS = YES;
879887
GCC_WARN_UNUSED_FUNCTION = YES;
888+
GCC_WARN_UNUSED_LABEL = YES;
889+
GCC_WARN_UNUSED_PARAMETER = YES;
880890
GCC_WARN_UNUSED_VARIABLE = YES;
881891
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
882892
ONLY_ACTIVE_ARCH = YES;
@@ -895,6 +905,7 @@
895905
CLANG_CXX_LIBRARY = "libc++";
896906
CLANG_ENABLE_MODULES = YES;
897907
CLANG_ENABLE_OBJC_ARC = YES;
908+
CLANG_UNDEFINED_BEHAVIOR_SANITIZER_NULLABILITY = YES;
898909
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
899910
CLANG_WARN_BOOL_CONVERSION = YES;
900911
CLANG_WARN_COMMA = YES;
@@ -903,14 +914,19 @@
903914
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
904915
CLANG_WARN_EMPTY_BODY = YES;
905916
CLANG_WARN_ENUM_CONVERSION = YES;
917+
CLANG_WARN_FLOAT_CONVERSION = YES;
918+
CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;
906919
CLANG_WARN_INFINITE_RECURSION = YES;
907920
CLANG_WARN_INT_CONVERSION = YES;
908921
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
922+
CLANG_WARN_NULLABLE_TO_NONNULL_CONVERSION = YES;
923+
CLANG_WARN_OBJC_EXPLICIT_OWNERSHIP_TYPE = YES;
909924
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
910925
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
911926
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
912927
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
913928
CLANG_WARN_STRICT_PROTOTYPES = YES;
929+
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
914930
CLANG_WARN_SUSPICIOUS_MOVE = YES;
915931
CLANG_WARN_UNREACHABLE_CODE = YES;
916932
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -921,9 +937,13 @@
921937
GCC_NO_COMMON_BLOCKS = YES;
922938
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
923939
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
940+
GCC_WARN_MISSING_PARENTHESES = YES;
941+
GCC_WARN_SHADOW = YES;
924942
GCC_WARN_UNDECLARED_SELECTOR = YES;
925943
GCC_WARN_UNINITIALIZED_AUTOS = YES;
926944
GCC_WARN_UNUSED_FUNCTION = YES;
945+
GCC_WARN_UNUSED_LABEL = YES;
946+
GCC_WARN_UNUSED_PARAMETER = YES;
927947
GCC_WARN_UNUSED_VARIABLE = YES;
928948
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
929949
OTHER_LDFLAGS = "-ObjC";

‎LayoutTest/TestCase/LYTLayoutFailingTestSnapshotRecorder.m‎

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ void SimpleLog(NSString *format, ...) {
1818
NSString *formattedString = [[NSString alloc] initWithFormat:format
1919
arguments:args];
2020
va_end(args);
21-
[[NSFileHandle fileHandleWithStandardOutput] writeData:[formattedString dataUsingEncoding:NSNEXTSTEPStringEncoding]];
21+
22+
NSData *data = [formattedString dataUsingEncoding:NSNEXTSTEPStringEncoding];
23+
if (data) {
24+
[[NSFileHandle fileHandleWithStandardOutput] writeData:data];
25+
}
2226
}
2327

2428
@interface NSString (XMLEscape)
@@ -74,11 +78,11 @@ - (instancetype)init {
7478
return self;
7579
}
7680

77-
- (void)testSuiteWillStart:(XCTestSuite *)testSuite {
81+
- (void)testSuiteWillStart:(__unused XCTestSuite *)testSuite {
7882
self.failedTestsDuringTestSuite = 0;
7983
}
8084

81-
- (void)testSuiteDidFinish:(XCTestSuite *)testSuite {
85+
- (void)testSuiteDidFinish:(__unused XCTestSuite *)testSuite {
8286
if (self.failedTestsDuringTestSuite > 0 && self.failingTestsSnapshotFolders.count > 0) {
8387
SimpleLog(@"\nSnapshots of failing tests can be found in:\n");
8488
for (NSString *path in self.failingTestsSnapshotFolders) {
@@ -88,7 +92,7 @@ - (void)testSuiteDidFinish:(XCTestSuite *)testSuite {
8892
}
8993
}
9094

91-
- (void)testBundleDidFinish:(NSBundle *)testBundle {
95+
- (void)testBundleDidFinish:(__unused NSBundle *)testBundle {
9296
// NOTE: For some reason, this never gets called
9397
// See #28 on Github
9498
if (self.failingTestsSnapshotFolders.count > 0) {
@@ -101,7 +105,7 @@ - (void)testBundleDidFinish:(NSBundle *)testBundle {
101105
}
102106
}
103107

104-
- (void)testCase:(XCTestCase *)testCase didFailWithDescription:(NSString *)description inFile:(nullable NSString *)filePath atLine:(NSUInteger)lineNumber {
108+
- (void)testCase:(XCTestCase *)testCase didFailWithDescription:(__unused NSString *)description inFile:(nullable __unused NSString *)filePath atLine:(__unused NSUInteger)lineNumber {
105109
if ([testCase isKindOfClass:[LYTLayoutTestCase class]]) {
106110
NSString *pathForSnapshots = [self commonRootPathForInvocationClass:[testCase class]];
107111
pathForSnapshots = [pathForSnapshots stringByAppendingString:@"/index.html"];
@@ -133,7 +137,7 @@ - (void)saveImageOfView:(UIView *)view withData:(NSDictionary *)data fromInvocat
133137
- (BOOL)shouldSaveImageOfViewAtPath:(NSString *)imagePath withInvocation:(NSInvocation *)invocation {
134138
if ([[NSFileManager defaultManager] fileExistsAtPath:imagePath]) {
135139
return NO;
136-
} else if ([LYTConfig sharedInstance].snapshotsToSavePerMethod != LYTSaveUnlimitedSnapshotsPerMethod &&
140+
} else if ([LYTConfig sharedInstance].snapshotsToSavePerMethod >= 0 &&
137141
[self numberOfImagesSavedForInvocation:invocation] >= [LYTConfig sharedInstance].snapshotsToSavePerMethod) {
138142
return NO;
139143
}
@@ -166,7 +170,10 @@ - (void)finishLog {
166170
NSFileHandle *fileHandler = [NSFileHandle fileHandleForUpdatingAtPath:filePath];
167171

168172
[fileHandler seekToEndOfFile];
169-
[fileHandler writeData:[footer dataUsingEncoding:NSUTF8StringEncoding]];
173+
NSData *footerData = [footer dataUsingEncoding:NSUTF8StringEncoding];
174+
if (footerData) {
175+
[fileHandler writeData:footerData];
176+
}
170177
[fileHandler closeFile];
171178
}
172179

@@ -197,7 +204,10 @@ - (void)appendViewWithWidth:(CGFloat)width
197204
NSFileHandle *fileHandler = [NSFileHandle fileHandleForUpdatingAtPath:filePath];
198205

199206
[fileHandler seekToEndOfFile];
200-
[fileHandler writeData:[errorHTML dataUsingEncoding:NSUTF8StringEncoding]];
207+
NSData *errorData = [errorHTML dataUsingEncoding:NSUTF8StringEncoding];
208+
if (errorData) {
209+
[fileHandler writeData:errorData];
210+
}
201211
[fileHandler closeFile];
202212
}
203213

‎LayoutTest/TestCase/LYTLayoutTestCase.m‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ - (void)runAmbiguousLayoutTestsWithSubview:(UIView *)subview view:(UIView *)view
226226

227227
#pragma mark - Testing
228228

229-
- (void)failTest:(NSString *)errorMessage view:(nullable UIView *)view {
229+
- (void)failTest:(NSString *)errorMessage view:(nullable __unused UIView *)view {
230230
XCTFail(@"%@", errorMessage);
231231
}
232232

@@ -264,12 +264,13 @@ + (BOOL)class:(Class)aClass includedInSet:(NSSet *)set {
264264
}
265265

266266
+ (nullable UIView *)firstSuperviewWithAccessibilityLabel:(UIView *)view {
267-
if (view.superview == nil) {
267+
UIView *superview = view.superview;
268+
if (superview == nil) {
268269
return nil;
269-
} else if (view.superview.accessibilityLabel != nil) {
270-
return view.superview;
270+
} else if (superview.accessibilityLabel != nil) {
271+
return superview;
271272
} else {
272-
return [self firstSuperviewWithAccessibilityLabel:view.superview];
273+
return [self firstSuperviewWithAccessibilityLabel:superview];
273274
}
274275
}
275276

‎LayoutTestBase.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |spec|
22
spec.name = 'LayoutTestBase'
3-
spec.version = '5.0.2'
3+
spec.version = '5.0.3'
44
spec.license = { :type => 'Apache License, Version 2.0' }
55
spec.homepage = 'https://linkedin.github.io/LayoutTest-iOS'
66
spec.authors = 'LinkedIn'

‎LayoutTestBase/Catalog/LYTCatalogCollectionViewController.m‎

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,39 +34,49 @@ - (instancetype)init {
3434
- (void)viewDidLoad {
3535
[super viewDidLoad];
3636

37-
[self.ViewProviderClass registerClassOnCollectionView:self.collectionView];
37+
Class<LYTViewCatalogProvider> viewProviderClass = self.ViewProviderClass;
38+
if (!viewProviderClass) {
39+
NSAssert(NO, @"No ViewProviderClass set");
40+
return;
41+
}
42+
43+
[viewProviderClass registerClassOnCollectionView:self.collectionView];
3844

3945
NSMutableArray *dataArray = [NSMutableArray array];
4046

4147
LYTTesterLimitResults limitResults = LYTTesterLimitResultsNoSizes;
42-
if ([(id)self.ViewProviderClass respondsToSelector:@selector(limitResultsForCatalogByAssumingDataValueIndependence)]) {
43-
if ([self.ViewProviderClass limitResultsForCatalogByAssumingDataValueIndependence]) {
48+
if ([viewProviderClass respondsToSelector:@selector(limitResultsForCatalogByAssumingDataValueIndependence)]) {
49+
if ([viewProviderClass limitResultsForCatalogByAssumingDataValueIndependence]) {
4450
limitResults &= LYTTesterLimitResultsLimitDataCombinations;
4551
}
4652
}
47-
[LYTLayoutPropertyTester runPropertyTestsWithViewProvider:self.ViewProviderClass
48-
limitResults:limitResults
49-
validation:^(UIView *view, NSDictionary *data, id context) {
50-
[dataArray addObject:data];
51-
}];
53+
[LYTLayoutPropertyTester runPropertyTestsWithViewProvider:viewProviderClass
54+
limitResults:limitResults
55+
validation:^(__unused UIView *view, NSDictionary *data, __unused id context) {
56+
[dataArray addObject:data];
57+
}];
5258
self.dataArray = dataArray;
5359
}
5460

5561
#pragma mark - Table view data source
5662

57-
- (CGSize)collectionView:(UICollectionView *)collectionView layout:(UICollectionViewLayout *)collectionViewLayout sizeForItemAtIndexPath:(NSIndexPath *)indexPath {
58-
return [self.ViewProviderClass sizeForCollectionViewCellForCatalogFromData:self.dataArray[indexPath.row] viewWidth:self.view.frame.size.width];
63+
- (CGSize)collectionView:(__unused UICollectionView *)collectionView
64+
layout:(__unused UICollectionViewLayout *)collectionViewLayout
65+
sizeForItemAtIndexPath:(NSIndexPath *)indexPath {
66+
return [self.ViewProviderClass sizeForCollectionViewCellForCatalogFromData:self.dataArray[(NSUInteger)indexPath.row] viewWidth:self.view.frame.size.width];
5967
}
6068

61-
- (NSInteger)collectionView:(UICollectionView *)collectionView numberOfItemsInSection:(NSInteger)section {
62-
return self.dataArray.count;
69+
- (NSInteger)collectionView:(__unused UICollectionView *)collectionView
70+
numberOfItemsInSection:(__unused NSInteger)section {
71+
return (NSInteger)self.dataArray.count;
6372
}
6473

65-
- (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cellForItemAtIndexPath:(NSIndexPath *)indexPath {
74+
- (UICollectionViewCell *)collectionView:(__unused UICollectionView *)collectionView
75+
cellForItemAtIndexPath:(NSIndexPath *)indexPath {
6676
UICollectionViewCell *cell = [self.collectionView dequeueReusableCellWithReuseIdentifier:[self.ViewProviderClass reuseIdentifier] forIndexPath:indexPath];
6777

6878
id context = nil;
69-
cell = (UICollectionViewCell *)[self.ViewProviderClass viewForData:self.dataArray[indexPath.row] reuseView:cell size:nil context:&context];
79+
cell = (UICollectionViewCell *)[self.ViewProviderClass viewForData:self.dataArray[(NSUInteger)indexPath.row] reuseView:cell size:nil context:&context];
7080

7181
return cell;
7282
}

‎LayoutTestBase/Catalog/LYTCatalogTableViewController.m‎

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,45 +26,49 @@ @implementation LYTCatalogTableViewController
2626
- (void)viewDidLoad {
2727
[super viewDidLoad];
2828

29+
Class<LYTViewCatalogProvider> viewProviderClass = self.ViewProviderClass;
30+
if (!viewProviderClass) {
31+
NSAssert(NO, @"No ViewProviderClass set");
32+
return;
33+
}
34+
2935
[self.ViewProviderClass registerClassOnTableView:self.tableView];
3036

3137
NSMutableArray *dataArray = [NSMutableArray array];
3238

3339
LYTTesterLimitResults limitResults = LYTTesterLimitResultsNoSizes;
34-
if ([(id)self.ViewProviderClass respondsToSelector:@selector(limitResultsForCatalogByAssumingDataValueIndependence)]) {
35-
if ([self.ViewProviderClass limitResultsForCatalogByAssumingDataValueIndependence]) {
40+
if ([viewProviderClass respondsToSelector:@selector(limitResultsForCatalogByAssumingDataValueIndependence)]) {
41+
if ([viewProviderClass limitResultsForCatalogByAssumingDataValueIndependence]) {
3642
limitResults &= LYTTesterLimitResultsLimitDataCombinations;
3743
}
3844
}
39-
[LYTLayoutPropertyTester runPropertyTestsWithViewProvider:self.ViewProviderClass
40-
limitResults:limitResults
41-
validation:^(UIView *view, NSDictionary *data, id context) {
42-
[dataArray addObject:data];
43-
}];
45+
[LYTLayoutPropertyTester runPropertyTestsWithViewProvider:viewProviderClass
46+
limitResults:limitResults
47+
validation:^(__unused UIView *view, NSDictionary *data, __unused id context) {
48+
[dataArray addObject:data];
49+
}];
4450
self.dataArray = dataArray;
4551

4652
self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
4753
}
4854

4955
#pragma mark - Table view data source
5056

51-
- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath
52-
{
53-
return [self.ViewProviderClass heightForTableViewCellForCatalogFromData:self.dataArray[indexPath.row]];
57+
- (CGFloat)tableView:(__unused UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath {
58+
return [self.ViewProviderClass heightForTableViewCellForCatalogFromData:self.dataArray[(NSUInteger)indexPath.row]];
5459
}
5560

56-
- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
57-
{
58-
return [self.dataArray count];
61+
- (NSInteger)tableView:(__unused UITableView *)tableView numberOfRowsInSection:(__unused NSInteger)section {
62+
return (NSInteger)self.dataArray.count;
5963
}
6064

6165
- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
62-
UITableViewCell *cell = [self.tableView dequeueReusableCellWithIdentifier:[self.ViewProviderClass reuseIdentifier] forIndexPath:indexPath];
66+
UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:[self.ViewProviderClass reuseIdentifier] forIndexPath:indexPath];
6367

6468
if ([(id)self.ViewProviderClass respondsToSelector:@selector(tableViewCellForCatalogFromData:reuseCell:)]) {
65-
cell = [self.ViewProviderClass tableViewCellForCatalogFromData:self.dataArray[indexPath.row] reuseCell:cell];
69+
cell = [self.ViewProviderClass tableViewCellForCatalogFromData:self.dataArray[(NSUInteger)indexPath.row] reuseCell:cell];
6670
} else {
67-
cell = (UITableViewCell *)[self.ViewProviderClass viewForData:self.dataArray[indexPath.row] reuseView:cell size:nil context:nil];
71+
cell = (UITableViewCell *)[self.ViewProviderClass viewForData:self.dataArray[(NSUInteger)indexPath.row] reuseView:cell size:nil context:nil];
6872
NSAssert([cell isKindOfClass:[UITableViewCell class]], @"If your view is not a UITableViewCell, you must implement cellForCatalogFromData:reuseCell:");
6973
}
7074

‎LayoutTestBase/Config/LYTConfig.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ NS_SWIFT_NAME(Config)
130130
/**
131131
Default snapshots to save per method.
132132
*/
133-
extern NSUInteger const LYTSaveUnlimitedSnapshotsPerMethod;
133+
extern NSInteger const LYTSaveUnlimitedSnapshotsPerMethod;
134134

135135
/**
136136
Limits the number of snapshots that will be saved for each method in a LYTLayoutTestCase. If a test has multiple XCTAsserts which can fail for each size/data iteration there is the possiblity that hundreds of snapshots will be produced. Setting this to a value of 0 or greater will limit the number of images saved.
@@ -139,7 +139,7 @@ extern NSUInteger const LYTSaveUnlimitedSnapshotsPerMethod;
139139
140140
Default: SaveUnlimitedSnapshotsPerMethod(-1) (Representing unlimited)
141141
*/
142-
@property (nonatomic) NSUInteger snapshotsToSavePerMethod;
142+
@property (nonatomic) NSInteger snapshotsToSavePerMethod;
143143

144144
/**
145145
Singleton accessor.

‎LayoutTestBase/Config/LYTConfig.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
@implementation LYTConfig
1414

15-
NSUInteger const LYTSaveUnlimitedSnapshotsPerMethod = -1;
15+
NSInteger const LYTSaveUnlimitedSnapshotsPerMethod = -1;
1616

1717
+ (instancetype)sharedInstance {
1818
static LYTConfig *sharedInstance = nil;

0 commit comments

Comments
 (0)