Using lmb_env for session startup filter & session db storage

Author: a.anokhin

session/src/lmbSessionDbStorage.class.php

@@ -34,10 +34,11 @@ class lmbSessionDbStorage implements lmbSessionStorage
   /**
    *  Constructor.
    *  @param lmbDbConnection database connection object
-   *  @param integer maximum session life time
    */
-  function __construct($db_connection, $max_life_time = null)
+  function __construct($db_connection)
   {
+    $max_life_time = lmb_env_get('LIMB_SESSION_DB_MAX_LIFE_TIME');
+
     $this->max_life_time = $max_life_time;
 
     $this->db = new lmbSimpleDb($db_connection);

session/tests/cases/lmbSessionDbStorageTest.class.php

@@ -2,9 +2,9 @@
 /*
  * Limb PHP Framework
  *
- * @link http://limb-project.com 
+ * @link http://limb-project.com
  * @copyright  Copyright © 2004-2009 BIT(http://bit-creative.com)
- * @license    LGPL http://www.gnu.org/copyleft/lesser.html 
+ * @license    LGPL http://www.gnu.org/copyleft/lesser.html
  */
 lmb_require('limb/session/src/lmbSessionDbStorage.class.php');
 lmb_require('limb/dbal/src/lmbSimpleDb.class.php');
@@ -183,7 +183,8 @@ function testStorageGcTrue()
 
   function testStorageGcUseSettedMaxLifeTime()
   {
-    $driver = new lmbSessionDbStorage($this->conn, $max_life_time = 500);
+    lmb_env_setor('LIMB_SESSION_DB_MAX_LIFE_TIME', 500);
+    $driver = new lmbSessionDbStorage($this->conn);
 
     $this->db->insert('lmb_session',
                           array('session_id' => "whatever",

web_app/src/filter/lmbSessionStartupFilter.class.php

@@ -29,7 +29,8 @@ class lmbSessionStartupFilter implements lmbInterceptingFilter
    */
   function run($filter_chain)
   {
-    $session_in_db = defined('LIMB_SESSION_USE_DB_DRIVER') ? LIMB_SESSION_USE_DB_DRIVER : false;
+    $session_in_db = lmb_env_get('LIMB_SESSION_USE_DB_DRIVER', false);
+
     if($session_in_db)
       $storage =  $this->_createDBSessionStorage();
     else
@@ -53,11 +54,9 @@ protected function _createNativeSessionStorage()
    */
   protected function _createDBSessionStorage()
   {
-    $lifetime = defined('LIMB_SESSION_DB_MAX_LIFE_TIME') ? LIMB_SESSION_DB_MAX_LIFE_TIME : null;
-
     lmb_require('limb/session/src/lmbSessionDbStorage.class.php');
     $db_connection = lmbToolkit :: instance()->getDefaultDbConnection();
-    return new lmbSessionDbStorage($db_connection, $lifetime);
+    return new lmbSessionDbStorage($db_connection);
   }
 }