fix(plugin-id/ui): harmonize actions column layout across Identity ListViews#30
Merged
Merged
Conversation
…s ListViews The actions column on the three Identity ListViews (User / Group / Company) showed two inconsistencies: - GroupListView was 120px, the other two were 100px - align="end" + a tight width pushed the two icon buttons (edit + delete) against the right edge, where they wrapped onto two lines on narrower viewports Aligning all three on width="120px" + align="center" so: - the two icon buttons sit horizontally on a single line at any reasonable viewport width - the column header and the buttons are centered in the cell Branch name is historical (originated as a single-file fix on GroupListView); the scope was extended after Norman's review to cover the three lists together for visual consistency.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harmonize the actions column on the three Identity ListViews
(User / Group / Company).
Finding
The review item mentioned the user list, but investigation showed
UserListView and CompanyListView were already aligned at width 100px —
GroupListView was the outlier at 120px.
However, 100px combined with
align: 'end'pushed the two actionicons (edit + delete) against the right edge where they wrapped onto
two lines on any viewport narrower than very wide — inconsistent AND
not usable.
Fix
Apply a single shared config to the actions column on all three
ListViews:
The three ListViews now share an identical actions column config.
Tested
Visual check with the three pages side by side:
Files
3 files, +3/-3 — User/Group/CompanyListView.vue.