Skip to content

Commit daf7521

Browse files
bsiaotickchongLightspark Eng
authored andcommitted
[ops] unify sparkcore and paycore searches into one (#22822)
## Reason The sparkcore vs paycore ent searches is kind of frustrating because it doesn't indicate if it exists in one or the other. So I wanted to combine both into a single search so you don't have to toggle the schema manually (and it'll show results for both schemas) ## Overview - deletes old searches for sparkcore and paycore - queries both schemas for results in new unified search input - search types are combined (defaults to auto if it doesn't exist for one of the schemas) - shows the schema on the actual ent! ## Test Plan works locally ![Screenshot 2025-12-24 at 6.08.51 PM.png](https://app.graphite.com/user-attachments/assets/58a9fb5e-b937-49eb-9f1e-ce2fb1d68e09.png) ![Screenshot 2025-12-24 at 6.08.56 PM.png](https://app.graphite.com/user-attachments/assets/8e456b16-b5a2-4910-8459-6cda78857ef2.png) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Unified search input consolidates results across schemas and shows schema on results. * CardPage header supports custom right-side content (used to show schema badges). * **Refactor** * Replaced two specialized search inputs with a single unified one for consistent behavior. * Inspector now uses a single link component for entity navigation for consistent styling. * **Chores** * Removed legacy per-schema search components and related query wiring. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> GitOrigin-RevId: 7ae439a34e2c04d40bf2163190a78179dfbf000a
1 parent 521c3bb commit daf7521

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

packages/ui/src/components/CardPage.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ type Props = {
2828
maxContentWidth?: number;
2929
rightContent?: React.ReactNode;
3030
preHeaderContent?: React.ReactNode;
31+
headerRightContent?: React.ReactNode;
3132
expandRight?: boolean;
3233
id?: string;
3334
};
@@ -43,6 +44,9 @@ export function CardPage(props: Props) {
4344
<Heading type="h1" m0>
4445
{props.title}
4546
</Heading>
47+
{props.headerRightContent && (
48+
<CardPageHeaderRight>{props.headerRightContent}</CardPageHeaderRight>
49+
)}
4650
</CardPageHeader>
4751
) : null;
4852

@@ -350,6 +354,11 @@ const CardPageHeader = styled.div<{ headerMarginBottom?: number }>`
350354
}
351355
`;
352356

357+
const CardPageHeaderRight = styled.div`
358+
display: flex;
359+
align-items: center;
360+
`;
361+
353362
export const CardPageContent = styled.div<CardPageContentProps>`
354363
${({
355364
maxContentWidth,

0 commit comments

Comments
 (0)