`Bolt11Invoice::payment_hash` should return a `PaymentHash`

[TheBlueMatt-macbook]

...now that PaymentHash is in lightning_types we can.

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Similar Issues

Related Issues

• PaymentPurpose in Event::PaymentClaimed missing preimage when using custom PaymentHash #4270

👤 Suggested Assignees

• Fedeparma74

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[psychemist]

i am working on this issue

[TheBlueMatt]

#4293 did most of the work, but there remain some types in raw invoices that also should be fixed.

[jgmcalpine]

Hi, I can pick this up.

[psychemist]

@jgmcalpine i'm working on a fix at the moment. i made updates in the merged pr linked above but the maintainers wanted more changes. i forgot to update on here, my bad.

[jgmcalpine]

@jgmcalpine i'm working on a fix at the moment. i made updates in the merge pr linked above but the maintainers wanted more chages. i forgot to update on here, my bad.

@psychemist Oh, apologies for the collision! I actually just finished implementing the full fix locally as a learning exercise (migrated the raw types, updated the builder, fixed the name collisions in tests, and updated the downstream usage in channelmanager/invoice_utils).

Since I have the branch ready and verified that it passes all tests and checks locally, would you mind if I put up the PR to save you the effort? I'm happy to stand down if you prefer to finish yours, though!

[psychemist]

@jgmcalpine nah, that's totally fine. i will be on the lookout for your fix so i can compare implementations 🚀