onremove comment

thetarnav · thetarnav · commit 53c608bd9393 · 2025-08-07T14:02:45.000+02:00
diff --git a/src/universal.ts b/src/universal.ts
@@ -164,7 +164,7 @@ export const insert: su.Renderer<SolidNode>['insert'] = (
         for (let i = 0; i < prev.length; i++) {
           let c = prev[i]!;
           if (c.parent !== el) {
-            (c as lng.ElementNode).onRemove?.(c as lng.ElementNode);
+            (c as lng.ElementNode).onRemove?.(c as lng.ElementNode); // ? Should this be called in effect?
             if (el.requiresLayout()) {
               lng.addToLayoutQueue(el);
             }

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ export const insert: su.Renderer<SolidNode>['insert'] = (`
`164`	`164`	`for (let i = 0; i < prev.length; i++) {`
`165`	`165`	`let c = prev[i]!;`
`166`	`166`	`if (c.parent !== el) {`
`167`		`- (c as lng.ElementNode).onRemove?.(c as lng.ElementNode);`
	`167`	`+ (c as lng.ElementNode).onRemove?.(c as lng.ElementNode); // ? Should this be called in effect?`
`168`	`168`	`if (el.requiresLayout()) {`
`169`	`169`	`lng.addToLayoutQueue(el);`
`170`	`170`	`}`