Improve codebase quality: fix bugs, modernize code, add CI (#131)

* Improve codebase quality: fix bugs, modernize code, add CI

Bug fixes:
- Fix error-handling bug in index.js where forEach loop called utils.error()
  (which throws) on every iteration with a shadowed variable
- Fix loose equality (==) to strict (===) in containsPattern and test
- Remove unnecessary regex 'g' flag on regexes used with .test(), eliminating
  brittle lastIndex state management

Modernization:
- Use Array.includes() instead of indexOf() !== -1
- Use Array.flat() instead of reduce(concat)
- Use arrow functions in utility callbacks

Tooling:
- Add ESLint 'lint' script to package.json
- Change 'test' script from watch mode to lint+unit (CI-friendly)
- Add eqeqeq ESLint rule to prevent future loose equality
- Add GitHub Actions CI workflow (Node 14/16/18/20 matrix)
- Update mock-fs from v4 to v5 for Node.js 22 compatibility (fixes 8 pre-existing test failures)

https://claude.ai/code/session_017GbwKxDk7oJN3tXXKSbUDg

* fix(ci): drop Node 14 and handle OpenSSL 3.0 in Node 18+

- Remove Node 14 from CI matrix (EOL, npm 6 can't parse lockfile v3)
- Set --openssl-legacy-provider for Node 18+ to fix webpack 4's
  use of the removed md4 hash algorithm (ERR_OSSL_EVP_UNSUPPORTED)

https://claude.ai/code/session_017GbwKxDk7oJN3tXXKSbUDg

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: liady

.eslintrc.js

@@ -11,5 +11,6 @@ module.exports = {
     },
     rules: {
         'no-prototype-builtins': 0,
+        eqeqeq: ['error', 'always'],
     },
 };

.github/workflows/ci.yml

@@ -0,0 +1,24 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [16, 18, 20]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - run: npm install
+      - run: npm run lint
+      - run: npm run unit
+        env:
+          NODE_OPTIONS: ${{ matrix.node-version >= 18 && '--openssl-legacy-provider' || '' }}

index.js

@@ -1,9 +1,7 @@
 const utils = require('./utils');
 
-const scopedModuleRegex = new RegExp(
-    '@[a-zA-Z0-9][\\w-.]+/[a-zA-Z0-9][\\w-.]+([a-zA-Z0-9./]+)?',
-    'g'
-);
+const scopedModuleRegex =
+    /@[a-zA-Z0-9][\w-.]+\/[a-zA-Z0-9][\w-.]+([a-zA-Z0-9./]+)?/;
 
 function getModuleName(request, includeAbsolutePaths) {
     let req = request;
@@ -14,8 +12,6 @@ function getModuleName(request, includeAbsolutePaths) {
     }
     // check if scoped module
     if (scopedModuleRegex.test(req)) {
-        // reset regexp
-        scopedModuleRegex.lastIndex = 0;
         return req.split(delimiter, 2).join(delimiter);
     }
     return req.split(delimiter)[0];
@@ -25,10 +21,7 @@ module.exports = function nodeExternals(options) {
     options = options || {};
     const mistakes = utils.validateOptions(options) || [];
     if (mistakes.length) {
-        mistakes.forEach((mistake) => {
-            utils.error(mistakes.map((mistake) => mistake.message));
-            utils.log(mistake.message);
-        });
+        utils.error(mistakes.map((mistake) => mistake.message));
     }
     const webpackInternalAllowlist = [/^webpack\/container\/reference\//];
     const allowlist = []