smartbooster#22 Migrate from travis to github actions

Author: nicolas-bastien

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
             - name: PHPStan
               run: phpstan analyse --no-progress
 
-    phpunit-lowest:
+    phpunit:
         runs-on: ubuntu-latest
         name: PHP 7.4 Test on ubuntu-latest
         steps:
@@ -78,7 +78,7 @@ jobs:
                   restore-keys: ${{ runner.os }}-composer-
 
             - name: Install dependencies
-              run: composer update --prefer-dist --prefer-lowest
+              run: composer install --prefer-dist
 
             - name: "Run tests with phpunit/phpunit"
               env:

Makefile

@@ -31,7 +31,7 @@ metrics:
 	vendor/bin/phpmetrics --report-html=build/phpmetrics.html src
 
 phpstan:
-	vendor/bin/phpstan analyse src --level=6 -c phpstan.neon
+	vendor/bin/phpstan analyse -c phpstan.neon
 
 #================================
 #           TEST

phpstan.neon

@@ -3,7 +3,8 @@ includes:
     - vendor/phpstan/phpstan-symfony/rules.neon
 
 parameters:
-	level: 5
-	paths:
-		- src
-		- tests
+    checkMissingIterableValueType: false
+    level: 6
+    paths:
+        - src
+        - tests

src/Entity/User/UserTrait.php

@@ -105,15 +105,15 @@ public function getId()
     /**
      * {@inheritdoc}
      */
-    public function getUsername()
+    public function getUsername(): string
     {
         return $this->email;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getEmail()
+    public function getEmail(): string
     {
         return $this->email;
     }
@@ -133,7 +133,7 @@ public function setEmail($email)
     /**
      * {@inheritdoc}
      */
-    public function getPassword()
+    public function getPassword(): string
     {
         return $this->password;
     }
@@ -181,7 +181,7 @@ public function setPlainPassword($plainPassword)
     /**
      * {@inheritdoc}
      */
-    public function eraseCredentials()
+    public function eraseCredentials(): void
     {
         $this->plainPassword = null;
     }

tests/Entity/User/UserTraitTest.php

@@ -11,7 +11,7 @@
  */
 class UserTraitTest extends TestCase
 {
-    public function testFullname()
+    public function testFullname(): void
     {
         $user = new User();
         $user->setLastName('Doe')

tests/Validator/Constraints/IsPasswordSafeValidatorTest.php

@@ -25,7 +25,7 @@ protected function getValidatorInstance()
      * @param string $expectedMessage
      * @dataProvider failPasswordProvider
      */
-    public function testValidationFail($value, $expectedMessage)
+    public function testValidationFail($value, $expectedMessage): void
     {
         $constraint = new IsPasswordSafe();
         $validator = $this->initValidator($expectedMessage);
@@ -52,7 +52,7 @@ public function failPasswordProvider()
      * @param string $value
      * @dataProvider validPasswordProvider
      */
-    public function testValidationOk($value)
+    public function testValidationOk($value): void
     {
         $constraint = new IsPasswordSafe();
         $validator = $this->initValidator();