Commit 165268e
committed
fix(sessions): the row actions are visible, and they render at all
Reported from the panel: the buttons on each session row are invisible. Two separate
problems, one of them a real bug rather than a preference.
1. BELOW THE LABEL THRESHOLD THE BUTTONS RENDERED EMPTY
@container (max-width: 390px) { .sesscard .sesslbl { display: none; } }
.sesscard .sessact .ci { display: none; } <- unconditional
The container query collapses each button to its ICON on a narrow panel. The icon was
hidden unconditionally, so it collapsed to NOTHING: six empty boxes with working tooltips,
which is exactly what the report shows — a blank rectangle and a clipped "Done" label.
The icon is the label's fallback, so it is now hidden only while the label is showing, and
it has a size: an inline <svg> carrying only a viewBox has no intrinsic one, so revealing it
without sizing it would have traded an invisible button for a broken one.
2. THE ACTIONS WERE HOVER-ONLY
They swapped in over the file·time line on :hover. A control that exists only while the
pointer is on it is one most people never find, and one a touch device cannot reach at all.
They are always present now, sharing line 2 with the metadata — quiet at .5 opacity so a
list of sessions still reads as a list, full strength on hover or keyboard focus. The row
keeps its fixed min-height, so nothing jumps. The metadata is the half that truncates.
Both surfaces get the same treatment. chat.html's /sessions modal had the identical
hover-swap and the same missing icon size; only sessionsView.html made it visible, by
hiding the icon outright. Fixing one and not the other is how the two drift.
The NO-JUMP test asserted the SWAP — file·time on rest, actions on hover — which is the
behaviour being removed, so it was rewritten rather than deleted: the row is still
fixed-height and still never grows, but it now carries both halves. A second test pins the
icon fallback and its size, which is the bug that was reported.
Verified by rendering the real card markup at 360px and 520px: six icons below the
threshold, six labels above it, the pinned star accented, the path truncating.
Guards, each bypass-verified by reverting the fix:
- the label collapsing to nothing (the reported bug)
- the fallback icon left unsized
- the actions hidden again; the hover-swap reintroduced
- the metadata no longer truncating, which pushes the actions out of the card
27 tests in sessionsUi, 34 suites green.1 parent eb28f30 commit 165268e
3 files changed
Lines changed: 60 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1233 | 1233 | | |
1234 | 1234 | | |
1235 | 1235 | | |
1236 | | - | |
| 1236 | + | |
1237 | 1237 | | |
1238 | 1238 | | |
1239 | 1239 | | |
| |||
1244 | 1244 | | |
1245 | 1245 | | |
1246 | 1246 | | |
1247 | | - | |
1248 | | - | |
1249 | | - | |
1250 | | - | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
1251 | 1256 | | |
1252 | 1257 | | |
1253 | 1258 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
100 | 103 | | |
101 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
102 | 114 | | |
103 | 115 | | |
104 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
257 | | - | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
258 | 262 | | |
259 | 263 | | |
260 | 264 | | |
261 | | - | |
262 | | - | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
263 | 289 | | |
264 | 290 | | |
265 | 291 | | |
| |||
0 commit comments