chore: snoarqube smells

Author: lduchosal

src/System.Net.IPNetwork/BigIntegerExtensions.cs

@@ -103,12 +103,9 @@ public static string ToOctalString(this BigInteger bigint)
             string octal = Convert.ToString(int24, 8);
 
             // Ensure leading zero exists if value is positive.
-            if (octal[0] != '0')
+            if (octal[0] != '0' && (bigint.Sign == 1))
             {
-                if (bigint.Sign == 1)
-                {
-                    base8.Append('0');
-                }
+                base8.Append('0');
             }
 
             // Append first converted chunk to StringBuilder.

src/TestProject/IPAddressExtensionTests.cs

@@ -95,7 +95,7 @@ e XOR'd with the byte count so the two sequences will be different. */
         hashInput[0] ^= (byte)byteCount;
 
         /* Loop many times. */
-        foreach (int i in Enumerable.Range(1, 1000))
+        foreach (int _ in Enumerable.Range(1, 1000))
         {
             /* Hash the current interation to get a new block of deterministic bytes. */
             hashInput = SHA256.HashData(hashInput);

src/TestProject/IPNetworkTest/IPNetworkCtorWithIpAndCidrTests.cs

@@ -31,7 +31,7 @@ public void CtorWithIpAndCidr2()
         Assert.ThrowsExactly<ArgumentNullException>(() =>
         {
             IPAddress ip = null;
-            var ipnetwork = new IPNetwork2(ip, 24);
+            var _ = new IPNetwork2(ip, 24);
         });
     }
 
@@ -45,7 +45,7 @@ public void CtorWithIpAndCidr3()
         {
             string ipaddress = "192.168.168.100";
             var ip = IPAddress.Parse(ipaddress);
-            var ipnetwork = new IPNetwork2(ip, 33);
+            var _ = new IPNetwork2(ip, 33);
         });
     }
 }

src/TestProject/IPNetworkTest/IPNetworkParseTests.cs

@@ -672,7 +672,7 @@ public void TestParse(string ipnetwork, string guess, string expected)
         {
             cidrGuess = CidrGuess.ClassFull;
         }
-        bool result = IPNetwork2.TryParse(ipnetwork, cidrGuess, out IPNetwork2 ipnetwork2);
+        bool _ = IPNetwork2.TryParse(ipnetwork, cidrGuess, out IPNetwork2 ipnetwork2);
         var ipnetworkExpected = IPNetwork2.Parse(expected);
 
         // This assert fails.

src/TestProject/IPNetworkTest/IPNetworkSubnetTests.cs

@@ -225,7 +225,7 @@ public void TestSubnet13()
             IPNetwork2 ipnetwork = IPNetwork2.IANA_CBLK_RESERVED1;
             byte cidr = 20;
             IPNetworkCollection subnets = ipnetwork.Subnet(cidr);
-            IPNetwork2 error = subnets[1000];
+            IPNetwork2 _ = subnets[1000];
         });
     }
 }

src/TestProject/IPNetworkTest/IPNetworkSupernetTests.cs

@@ -27,10 +27,9 @@ public void TestSupernetInternal1()
     [TestMethod]
     public void TestSupernetInternal2()
     {
-        IPNetwork2 result;
         Assert.ThrowsExactly<ArgumentNullException>(() =>
         {
-            IPNetwork2.InternalSupernet(false, null, null, out result);
+            IPNetwork2.InternalSupernet(false, null, null, out var _);
         });
     }
 

src/TestProject/IPNetworkTest/IPNetworkTrySupernetTests.cs

@@ -35,10 +35,9 @@ public void TestTrySupernet2()
         {
             IPNetwork2 network1 = null;
             var network2 = IPNetwork2.Parse("192.168.1.1/24");
-            IPNetwork2 supernet;
 
 #pragma warning disable 0618
-            IPNetwork2.TrySupernet(network1, network2, out supernet);
+            IPNetwork2.TrySupernet(network1, network2, out var _);
 #pragma warning restore 0618
         });
     }

src/TestProject/IPNetworkV6/IPNetworkV6CtorWithIpAndCidrTests.cs

@@ -32,7 +32,7 @@ public void CtorWithIpAndCidr2()
         {
             string ipaddress = "2001:db8::";
             var ip = IPAddress.Parse(ipaddress);
-            var ipn = new IPNetwork2(ip, 129);
+            var _ = new IPNetwork2(ip, 129);
         });
     }
 }

src/TestProject/IPNetworkV6/IPNetworkV6SubnetTests.cs

@@ -160,7 +160,7 @@ public void TestSubnet13()
             var ipnetwork = IPNetwork2.Parse("2001:db08::/64");
             byte cidr = 70;
             IPNetworkCollection subnets = ipnetwork.Subnet(cidr);
-            IPNetwork2 error = subnets[1000];
+            IPNetwork2 _ = subnets[1000];
         });
     }
 

src/TestProject/IPNetworkV6/IPNetworkV6TrySupernetTests.cs

@@ -35,9 +35,8 @@ public void TestTrySupernet2()
         {
             IPNetwork2 network1 = null;
             var network2 = IPNetwork2.Parse("2001:db8::/64");
-            IPNetwork2 supernet;
 #pragma warning disable 0618
-            IPNetwork2.TrySupernet(network1, network2, out supernet);
+            IPNetwork2.TrySupernet(network1, network2, out var _);
 #pragma warning restore 0618
         });
     }