Skip to content

Commit bb9e5a3

Browse files
lduchosallduchosal
committed
fix: dotnet 10 / test runner
1 parent 1a69eb8 commit bb9e5a3

5 files changed

Lines changed: 2 additions & 23 deletions

File tree

‎src/TestProject/IPNetworkTest/IPNetworkToNetmaskTests.cs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ public void ToNetmaskNegative()
4545
Assert.ThrowsExactly<ArgumentOutOfRangeException>(() =>
4646
{
4747
byte cidr = 0;
48-
cidr--;
49-
IPNetwork2.ToNetmask(cidr, AddressFamily.InterNetwork);
48+
IPNetwork2.ToNetmask(--cidr, AddressFamily.InterNetwork);
5049
});
5150
}
5251

‎src/TestProject/IPNetworkV6/IPNetworkV6ParseStringTests.cs‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,12 @@ public void TestParseString7_Uppercase_ipv6_must_parse()
147147
string lastUsable = "2fff:ffff:123:f:ffff:ffff:ffff:ffff";
148148
byte cidr = 60;
149149

150-
// BigInteger usable = 295147905179352825856;
151150
var ipnetwork = IPNetwork2.Parse(ipaddress);
152151
Assert.AreEqual(network, ipnetwork.Network.ToString());
153152
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
154153
Assert.IsNull(ipnetwork.Broadcast, "Broadcast");
155154
Assert.AreEqual(cidr, ipnetwork.Cidr);
156155

157-
// Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
158156
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
159157
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
160158
}
@@ -173,14 +171,12 @@ public void TestParseString8_Uppercase_ipv6_must_parse()
173171
string lastUsable = "2fff:fffe:123:f:ffff:ffff:ffff:ffff";
174172
byte cidr = 60;
175173

176-
// BigInteger usable = 295147905179352825856;
177174
var ipnetwork = IPNetwork2.Parse(ipaddress);
178175
Assert.AreEqual(network, ipnetwork.Network.ToString());
179176
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
180177
Assert.IsNull(ipnetwork.Broadcast, "Broadcast");
181178
Assert.AreEqual(cidr, ipnetwork.Cidr);
182179

183-
// Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
184180
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
185181
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
186182
}
@@ -199,14 +195,12 @@ public void TestParseString9_Uppercase_ipv6_must_parse()
199195
string lastUsable = "2fff:fffc:123:f:ffff:ffff:ffff:ffff";
200196
byte cidr = 60;
201197

202-
// BigInteger usable = 295147905179352825856;
203198
var ipnetwork = IPNetwork2.Parse(ipaddress);
204199
Assert.AreEqual(network, ipnetwork.Network.ToString());
205200
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
206201
Assert.IsNull(ipnetwork.Broadcast, "Broadcast");
207202
Assert.AreEqual(cidr, ipnetwork.Cidr);
208203

209-
// Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
210204
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
211205
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
212206
}
@@ -225,14 +219,12 @@ public void TestParseString10_Uppercase_ipv6_must_parse()
225219
string lastUsable = "2fff:fffa:123:f:ffff:ffff:ffff:ffff";
226220
byte cidr = 60;
227221

228-
// BigInteger usable = 295147905179352825856;
229222
var ipnetwork = IPNetwork2.Parse(ipaddress);
230223
Assert.AreEqual(network, ipnetwork.Network.ToString());
231224
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
232225
Assert.IsNull(ipnetwork.Broadcast, "Broadcast");
233226
Assert.AreEqual(cidr, ipnetwork.Cidr);
234227

235-
// Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
236228
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
237229
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
238230
}
@@ -251,14 +243,12 @@ public void TestParseString11_Uppercase_ipv6_must_parse()
251243
string lastUsable = "ffff:fff1:123:f:ffff:ffff:ffff:ffff";
252244
byte cidr = 60;
253245

254-
// BigInteger usable = 295147905179352825856;
255246
var ipnetwork = IPNetwork2.Parse(ipaddress);
256247
Assert.AreEqual(network, ipnetwork.Network.ToString());
257248
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
258249
Assert.IsNull(ipnetwork.Broadcast, "Broadcast");
259250
Assert.AreEqual(cidr, ipnetwork.Cidr);
260251

261-
// Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
262252
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
263253
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
264254
}

‎src/TestProject/IPNetworkV6/IPNetworkV6ParseTests.cs‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public void TestParsev6_128()
5454
string network = "2001:db8::";
5555
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
5656

57-
// string broadcast = "2001:db8::";
5857
string firstUsable = "2001:db8::";
5958
string lastUsable = "2001:db8::";
6059
byte cidr = 128;
@@ -83,7 +82,6 @@ public void TestParsev6_127()
8382
string network = "2001:db8::";
8483
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:fffe";
8584

86-
// string broadcast = "2001:db8::1";
8785
string firstUsable = "2001:db8::";
8886
string lastUsable = "2001:db8::1";
8987
byte cidr = 127;
@@ -112,7 +110,6 @@ public void TestParsev6_126()
112110
string network = "2001:db8::";
113111
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:fffc";
114112

115-
// string broadcast = "2001:db8::3";
116113
string firstUsable = "2001:db8::";
117114
string lastUsable = "2001:db8::3";
118115
byte cidr = 126;
@@ -141,7 +138,6 @@ public void TestParsev6_125()
141138
string network = "2001:db8::";
142139
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:fff8";
143140

144-
// string broadcast = "2001:db8::7";
145141
string firstUsable = "2001:db8::";
146142
string lastUsable = "2001:db8::7";
147143
byte cidr = 125;
@@ -170,7 +166,6 @@ public void TestParsev6_124()
170166
string network = "2001:db8::";
171167
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:fff0";
172168

173-
// string broadcast = "2001:db8::f";
174169
string firstUsable = "2001:db8::";
175170
string lastUsable = "2001:db8::f";
176171
byte cidr = 124;
@@ -199,7 +194,6 @@ public void TestParsev6_123()
199194
string network = "2001:db8::";
200195
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffe0";
201196

202-
// string broadcast = "2001:db8::1f";
203197
string firstUsable = "2001:db8::";
204198
string lastUsable = "2001:db8::1f";
205199
byte cidr = 123;
@@ -228,7 +222,6 @@ public void TestParsev6_112()
228222
string network = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:0";
229223
string netmask2 = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:0";
230224

231-
// string broadcast = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
232225
string firstUsable = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:0";
233226
string lastUsable = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
234227
byte cidr = 112;
@@ -257,7 +250,6 @@ public void TestParsev6_64()
257250
string network = "ffff:ffff:ffff:ffff::";
258251
string netmask2 = "ffff:ffff:ffff:ffff::";
259252

260-
// string broadcast = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
261253
string firstUsable = "ffff:ffff:ffff:ffff::";
262254
string lastUsable = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
263255
byte cidr = 64;
@@ -286,7 +278,6 @@ public void TestParsev6_16()
286278
string network = "ffff::";
287279
string netmask2 = "ffff::";
288280

289-
// string broadcast = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
290281
string firstUsable = "ffff::";
291282
string lastUsable = "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff";
292283
byte cidr = 16;

‎src/TestProject/SerializeXmlTest.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public void Test_Serialize_Xml()
2525

2626
string result = Encoding.UTF8.GetString(mem.ToArray());
2727

28-
// string expected = $@"<?xml version=""1.0"" encoding=""utf-8""?>{Environment.NewLine}<IPNetwork xmlns:xsi=""http://www.w3.org/2001/XMLSchema-instance"" xmlns:xsd=""http://www.w3.org/2001/XMLSchema"">{Environment.NewLine} <Value>10.0.0.0/8</Value>{Environment.NewLine}</IPNetwork>";
2928
bool ok = result.Contains("<Value>10.0.0.0/8</Value>");
3029

3130
Assert.IsTrue(ok, result);

‎src/TestProject/TestProject.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<NoWarn>SA1010</NoWarn>
1313
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1414
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
15-
<EnableMSTestRunner>true</EnableMSTestRunner>
15+
<TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
1616
</PropertyGroup>
1717

1818
<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">

0 commit comments

Comments
 (0)