fix(sparql-qlever): filter unsupported MIME types before downloading (#214)

- Check supportedFormats before download loop to avoid wasting
  bandwidth on distributions that will fail after download
- Extract MIME-to-format mapping into a reusable Map
- Simplify fileFormatFromMimeType to use map lookup

Author: ddeboer

packages/sparql-qlever/src/importer.ts

@@ -13,6 +13,14 @@ import { basename, dirname } from 'path';
 import { writeFile } from 'node:fs/promises';
 import { TaskRunner } from '@lde/task-runner';
 
+type fileFormat = 'nt' | 'nq' | 'ttl';
+
+const supportedFormats = new Map<string, fileFormat>([
+  ['application/n-triples', 'nt'],
+  ['application/n-quads', 'nq'],
+  ['text/turtle', 'ttl'],
+]);
+
 export interface Options {
   taskRunner: TaskRunner<unknown>;
   indexName?: string;
@@ -52,7 +60,8 @@ export class Importer implements ImporterInterface {
       .getDownloadDistributions()
       .filter(
         (distribution): distribution is Distribution & { mimeType: string } =>
-          distribution.mimeType !== undefined,
+          distribution.mimeType !== undefined &&
+          supportedFormats.has(distribution.mimeType),
       );
     if (downloadDistributions.length === 0) {
       return new NotSupported();
@@ -92,16 +101,11 @@ export class Importer implements ImporterInterface {
   }
 
   private fileFormatFromMimeType(mimeType: string): fileFormat {
-    switch (mimeType) {
-      case 'application/n-triples':
-        return 'nt';
-      case 'application/n-quads':
-        return 'nq';
-      case 'text/turtle':
-        return 'ttl';
-      default:
-        throw new Error(`Unsupported media type: ${mimeType}`);
+    const format = supportedFormats.get(mimeType);
+    if (format === undefined) {
+      throw new Error(`Unsupported media type: ${mimeType}`);
     }
+    return format;
   }
 
   private async index(file: string, format: fileFormat): Promise<void> {
@@ -127,5 +131,3 @@ export class Importer implements ImporterInterface {
     await this.taskRunner.wait(indexTask);
   }
 }
-
-type fileFormat = 'nt' | 'nq' | 'ttl';

packages/sparql-qlever/vite.config.ts

@@ -12,12 +12,12 @@ export default mergeConfig(
       },
       coverage: {
         thresholds: {
-          lines: 78.04,
+          lines: 82.92,
           functions: 100,
-          branches: 45.45,
-          statements: 78.04,
+          branches: 54.54,
+          statements: 82.92,
         },
       },
     },
-  })
+  }),
 );