From 84eae5672a7b6bdc4316363bb89fc254d9b5d285 Mon Sep 17 00:00:00 2001
From: Lee Calcote <leecalcote@gmail.com>
Date: Wed, 6 May 2026 01:51:59 -0500
Subject: [PATCH] =?UTF-8?q?fix(collab):=20rename=20useRoomActivity=20param?=
 =?UTF-8?q?=20provider=5Furl=20=E2=86=92=20providerUrl?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Aligns the UseRoomActivityParams interface and CollaborationConfigParams
interface with the canonical camelCase wire-format contract defined in
meshery/schemas. All internal usages of provider_url throughout the hook
implementation (destructuring, guards, effect dependency array, and
forwarding to getCollaborationConfig) are updated to providerUrl.

Note: user_map in UserMapChangeMessage is intentionally left as-is — it
is an incoming WebSocket message field name dictated by the server
protocol, not a hook parameter.

Signed-off-by: Lee Calcote <leecalcote@gmail.com>
---
 src/hooks/useRoomActivity.ts | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/hooks/useRoomActivity.ts b/src/hooks/useRoomActivity.ts
index b295b30fc..7627ce7d9 100644
--- a/src/hooks/useRoomActivity.ts
+++ b/src/hooks/useRoomActivity.ts
@@ -13,7 +13,7 @@ interface UserProfile {
 }
 
 interface CollaborationConfigParams {
-  provider_url: string;
+  providerUrl: string;
   getUserProfile: () => Promise<{ data: UserProfile }>;
   getUserAccessToken: () => Promise<{ data: string }>;
 }
@@ -47,7 +47,7 @@ interface UserMapping {
 }
 
 interface UseRoomActivityParams {
-  provider_url?: string;
+  providerUrl?: string;
   getUserProfile?: () => Promise<{ data: UserProfile }>;
   getUserAccessToken?: () => Promise<{ data: string }>;
 }
@@ -100,7 +100,7 @@ const getSignalingUrlFromProviderUrl = (providerUrl: string): string => {
  * Gets collaboration configuration for WebRTC
  */
 export const getCollaborationConfig = async ({
-  provider_url,
+  providerUrl,
   getUserProfile,
   getUserAccessToken
 }: CollaborationConfigParams): Promise<CollaborationConfig> => {
@@ -116,7 +116,7 @@ export const getCollaborationConfig = async ({
   };
 
   return {
-    signalingUrl: [getSignalingUrlFromProviderUrl(provider_url)],
+    signalingUrl: [getSignalingUrlFromProviderUrl(providerUrl)],
     user: userProfile,
     authToken: accessToken,
     refreshAuthToken: refreshToken,
@@ -135,18 +135,18 @@ export const getCollaborationConfig = async ({
 const subscribeToRoomActivity = async (
   wsRef: React.MutableRefObject<WebSocket | null>,
   onUserMapChange: (userMap: UserMapping) => void,
-  provider_url: string,
+  providerUrl: string,
   getUserProfile: () => Promise<{ data: UserProfile }>,
   getUserAccessToken: () => Promise<{ data: string }>
 ): Promise<void> => {
-  if (!provider_url || !getUserProfile || !getUserAccessToken) {
+  if (!providerUrl || !getUserProfile || !getUserAccessToken) {
     console.warn('Missing required parameters for subscription');
     return;
   }
 
   try {
     const config = await getCollaborationConfig({
-      provider_url,
+      providerUrl,
       getUserProfile,
       getUserAccessToken
     });
@@ -187,7 +187,7 @@ const subscribeToRoomActivity = async (
  */
 export const useRoomActivity = (
   {
-    provider_url,
+    providerUrl,
     getUserProfile,
     getUserAccessToken
   }: UseRoomActivityParams = {} as UseRoomActivityParams
@@ -197,11 +197,11 @@ export const useRoomActivity = (
 
   useEffect(() => {
     // -> all parameters check
-    if (provider_url && getUserProfile && getUserAccessToken) {
+    if (providerUrl && getUserProfile && getUserAccessToken) {
       subscribeToRoomActivity(
         wsRef,
         setAllRoomsUserMapping,
-        provider_url,
+        providerUrl,
         getUserProfile,
         getUserAccessToken
       );
@@ -215,7 +215,7 @@ export const useRoomActivity = (
         ws.close();
       }
     };
-  }, [provider_url, getUserProfile, getUserAccessToken]);
+  }, [providerUrl, getUserProfile, getUserAccessToken]);
 
   return [allRoomsUserMapping, wsRef];
 };