rebase data system config

Author: kinyoklion

packages/sdk/browser/example/src/app.ts

@@ -25,7 +25,8 @@ statusBox.appendChild(document.createTextNode('Initializing...'));
 
 const main = async () => {
   const ldclient = createClient(clientSideID, context, {
-    useFDv2: true,
+    // @ts-ignore dataSystem is @internal — experimental FDv2 opt-in
+    dataSystem: {},
   });
   const render = () => {
     const flagValue = ldclient.variation(flagKey, false);
@@ -41,10 +42,10 @@ const main = async () => {
     );
   });
 
-  // Listen for flag changes
-  ldclient.on('change', () => {
-    render();
-  });
+  // // Listen for flag changes
+  // ldclient.on('change', () => {
+  //   render();
+  // });
 
   ldclient.start();
 

packages/sdk/browser/src/BrowserClient.ts

@@ -79,30 +79,23 @@ class BrowserClientImpl extends LDClientImpl {
     const { eventUrlTransformer } = validatedBrowserOptions;
     const endpoints = browserFdv1Endpoints(clientSideId);
 
-    const dataManagerFactory = validatedBrowserOptions.useFDv2
-      ? (
-          flagManager: FlagManager,
-          configuration: Configuration,
-          baseHeaders: LDHeaders,
-          emitter: LDEmitter,
-          _diagnosticsManager?: internal.DiagnosticsManager,
-        ) =>
-          new BrowserFDv2DataManager(
+    const dataManagerFactory = (
+      flagManager: FlagManager,
+      configuration: Configuration,
+      baseHeaders: LDHeaders,
+      emitter: LDEmitter,
+      diagnosticsManager?: internal.DiagnosticsManager,
+    ) =>
+      configuration.dataSystem
+        ? new BrowserFDv2DataManager(
             platform,
             flagManager,
             clientSideId,
             configuration,
             baseHeaders,
             emitter,
           )
-      : (
-          flagManager: FlagManager,
-          configuration: Configuration,
-          baseHeaders: LDHeaders,
-          emitter: LDEmitter,
-          diagnosticsManager?: internal.DiagnosticsManager,
-        ) =>
-          new BrowserDataManager(
+        : new BrowserDataManager(
             platform,
             flagManager,
             clientSideId,

packages/sdk/browser/src/options.ts

@@ -59,15 +59,6 @@ export interface BrowserOptions extends Omit<LDOptionsBase, 'initialConnectionMo
    * A list of plugins to be used with the SDK.
    */
   plugins?: LDPlugin[];
-
-  /**
-   * Opt-in to the FDv2 data delivery protocol. When enabled, the SDK uses
-   * the new `/sdk/poll/eval` and `/sdk/stream/eval` endpoints with the
-   * FDv2 protocol handler and orchestrator.
-   *
-   * Default: false
-   */
-  useFDv2?: boolean;
 }
 
 export interface ValidatedOptions {
@@ -76,23 +67,20 @@ export interface ValidatedOptions {
   streaming?: boolean;
   automaticBackgroundHandling?: boolean;
   plugins: LDPlugin[];
-  useFDv2: boolean;
 }
 
 const optDefaults = {
   fetchGoals: true,
   eventUrlTransformer: (url: string) => url,
   streaming: undefined,
   plugins: [],
-  useFDv2: false,
 };
 
 const validators: { [Property in keyof BrowserOptions]: TypeValidator | undefined } = {
   fetchGoals: TypeValidators.Boolean,
   eventUrlTransformer: TypeValidators.Function,
   streaming: TypeValidators.Boolean,
   plugins: TypeValidators.createTypeArray('LDPlugin', {}),
-  useFDv2: TypeValidators.Boolean,
 };
 
 function withBrowserDefaults(opts: BrowserOptions): BrowserOptions {