Feature/required validator

[weierophinney]

These allows manage the required message like any other ValidatorInterface element.

Note: While you can add the validator manually the flag setRequired must be set too

  $input = new Input();
  $input->setRequired(true);empty value instead *not set*.
  $input->getValidatorChain()->attach(
      new Zend\InputFilter\Validator\Required(),
      true                             // break chain on failure

  );

  $inputSpecification = [
    'required'   => true,
    'validators' => [
      [
        'break_chain_on_failure' => true,
        'name'                   => 'Zend\\InputFilter\\Validator\\Required',
      ],
    ],
  ];

Note: setRequired(false) may not be enough and you will need remove the validator from the chain.

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62

[weierophinney]

Inject a validator in the chain make difficult reset the input state for to validate different values or transititions set <=> not set

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

I haven't tried running this yet, but I like the idea.

Why must "the flag setRequired" be set when adding the validator manually? Wouldn't it be better to just deprecate the flag?

---

Originally posted by @larsnystrom at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

Because the validator does not validate the input value (https://github.com/zendframework/zend-inputfilter/pull/62/files#diff-5e41c64803af5c0ad8ad84c3e25c834cR412)

I didn't resolve how to make to replace the whole required funcionallity with the validator.

This is needed too https://github.com/zendframework/zend-inputfilter/blob/master/src/BaseInputFilter.php#L253

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

Hmm, yeah that's true. Do you think it would be possible to use the $data array as $context instead of the raw values? That would enable the Required-validator to check whether a key exists without having a reference to the input object.

You would have to inject the input's name in the Required-validator's constructor as well, so the validator knew which key to look for.

What do you think?

---

Originally posted by @larsnystrom at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

IIRC every input is present in $context with the default value of null.

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

Also rely on $context makes the input dependant of InputFilter implementation and can't be used standalone.

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

The problem is that they're initialized to null. Null is still a value, and would pass the required-validator. So we need the original input data, where the the input is not present.

I don't think relying on $context makes the Input dependent on the InputFilter implementation. The Input::isValid() method is already accepting a $context parameter. We can control the default value of that parameter inside the Input class.

1. If no $context parameter is provided, and if there is no value, then set the $context to [].
2. If no $context parameter is provided, and if there is a value, then set the $context to ['inputName' => $val].
3. If a $context parameter is provided, then use that $context.

---

Originally posted by @larsnystrom at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

Even if looking in $context is needed to know what input name to search.

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

Yes, that's why the input's name must be injected into the validator. If you add a RequiredValidator::setName() method, it will be compatible with the plugin manager.

---

Originally posted by @larsnystrom at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

I start to think the best option could be to have 2 validator chains. One for validate the data and another one for validate the input state.

Something like this

• Is required or not (RequiredValidator::isValid(input))
• Data is valid or not (DataValidator::isValid(Input))
  • Data is valid because has X characters (FooValidator::isValid(data))
  • Data is valid because exists on DB

---

Originally posted by @Maks3w at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

I just realized that my idea doesn't work. (The absence of a Required-validator wouldn't be equivalent to setRequired(false), since setRequired(false) implies not running any validators, but an absent Required-validator wouldn't give any information concerning whether to run the other validators.)

Two validator chains might be a good idea.

---

Originally posted by @larsnystrom at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

IMO, if we are going to have a Required validator, then we really can't also have a required flag without causing confusion.

---

Originally posted by @akrabat at zendframework/zend-inputfilter#62 (comment)

[weierophinney]

I agree with @akrabat

---

Originally posted by @stefanotorresi at zendframework/zend-inputfilter#62 (comment)