Skip to content

feat(COD-7048): use new caching mechanism for docker image#266

Merged
baltoiteodor merged 1 commit into
mainfrom
teodor/COD-7048
Jun 8, 2026
Merged

feat(COD-7048): use new caching mechanism for docker image#266
baltoiteodor merged 1 commit into
mainfrom
teodor/COD-7048

Conversation

@baltoiteodor

@baltoiteodor baltoiteodor commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

tested here: https://github.com/lacework-dev/WebGoat/actions/runs/26957051714/job/79541710114

All runs resulted in the same cache key: 2a89eac40b5eb64fbdb20341afae046cdc396cc10b4575b417c61868b170d107

Comment thread src/util.ts Outdated
}
}

export async function generateCacheKey(): Promise<string | undefined> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to reuse the function runCodesec but with an extra parameter compteCacheKey in order to make sure that we using the exact same scan parameters when calculating the cache key and when running the scans.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good

nit

nit

test with latest image

try catch block for docker rm
@baltoiteodor baltoiteodor marked this pull request as ready for review June 8, 2026 14:30
@baltoiteodor baltoiteodor merged commit 2f81d52 into main Jun 8, 2026
4 checks passed
@baltoiteodor baltoiteodor deleted the teodor/COD-7048 branch June 8, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants