Implement UTs for WorkloadReconciler predicate functions

[tenzen-y]

What would you like to be cleaned:

I'd propose implementing UTs for the WorkloadReconciler predicate functions (Create, Update, ...).

kueue/pkg/controller/core/workload_controller.go

Line 805 in b7fdcd4

func (r *WorkloadReconciler) Create(e event.TypedCreateEvent[*kueue.Workload]) bool {

kueue/pkg/controller/core/workload_controller.go

Line 839 in b7fdcd4

func (r *WorkloadReconciler) Delete(e event.TypedDeleteEvent[*kueue.Workload]) bool {

kueue/pkg/controller/core/workload_controller.go

Line 873 in b7fdcd4

func (r *WorkloadReconciler) Update(e event.TypedUpdateEvent[*kueue.Workload]) bool {

kueue/pkg/controller/core/workload_controller.go

Line 1007 in b7fdcd4

func (r *WorkloadReconciler) Generic(e event.TypedGenericEvent[*kueue.Workload]) bool {

Why is this needed:

The WorkloadReconciler predicates are very complicated, but we have no UT. So, I believe that adding UTs stabilizes the workload controller.

[tenzen-y]

cc @mimowo @gabesaba

[mimowo]

cc @Singularity23x0 who is currently working on the related refactoring as #5310

Generally the idea is to reduce the amount of code in the event handlers and move the logic to Reconcile.

[tenzen-y]

cc @Singularity23x0 who is currently working on the related refactoring as #5310

Generally the idea is to reduce the amount of code in the event handlers and move the logic to Reconcile.

Thank you for sharing that. I guess that we still have predicates even after moving some logic to reconcilers.
Or do @mimowo you assume that we completely remove WorkloadReconciler predicates?

[mimowo]

We will still have some code there for sure, but maybe adding the tests now (before refactoring) will mean the need to rewrite them. I think improving the integration tests before the refactoring would be particularly useful to ensure nothing breaks in the process.

[tenzen-y]

We will still have some code there for sure, but maybe adding the tests now (before refactoring) will mean the need to rewrite them. I think improving the integration tests before the refactoring would be particularly useful to ensure nothing breaks in the process.

I don't request to add UTs before refactoring. We can work on that after predicates refacotring for sure.